Skip to content

Fix various bugs #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lsmith77 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix various bugs #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cf2373
do not modify urls
lsmith77 Feb 18, 2016
14088fa
ensure that existing menu's are overwritten rather than appended into
lsmith77 Feb 18, 2016
6e45a8e
properly handle custom post types
lsmith77 Feb 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,10 @@ public function import_json( $file, $mode = 'append', $missing = 'skip', $defaul
if ( isset( $menu->location ) && isset( $locations[ $menu->location ] ) ) :
$menu_id = $locations[ $menu->location ];
elseif ( isset( $menu->name ) ) :
// If we can't find a menu by this name, create one.
if ( $menu_object = wp_get_nav_menu_object( $menu->name ) ) :
$menu_id = $menu_object->term_id;
else :
$menu_object = wp_create_nav_menu( $menu->name );
if ( isset( $menu_object->term_id ) ) {
$menu_id = $menu_object->term_id;
} else {
continue;
}
wp_delete_nav_menu($menu->name);
endif;
$menu_id = wp_create_nav_menu( $menu->name );
else : // if no location or name is supplied, we have nowhere to put any additional info in this object.
continue;
endif;
Expand All @@ -123,9 +116,9 @@ public function import_json( $file, $mode = 'append', $missing = 'skip', $defaul
'menu-item-status' => 'publish'
);

if ( isset( $item->page ) && $page = get_page_by_path( $item->page ) ) { // @todo support lookup by title
if ( isset( $item->page ) && $page = get_page_by_path( $item->page, OBJECT, $item->object ) ) { // @todo support lookup by title
$item_array['menu-item-type'] = 'post_type';
$item_array['menu-item-object'] = 'page';
$item_array['menu-item-object'] = $item->object;
$item_array['menu-item-object-id'] = $page->ID;
$item_array['menu-item-title'] = ( $item_array['menu-item-title'] ) ?: $page->post_title;
} elseif ( isset ( $item->taxonomy ) && isset( $item->term ) && $term = get_term_by( 'name', $item->term, $item->taxonomy ) ) {
Expand All @@ -134,7 +127,7 @@ public function import_json( $file, $mode = 'append', $missing = 'skip', $defaul
$item_array['menu-item-object-id'] = $term->term_id;
$item_array['menu-item-title'] = ( $item_array['menu-item-title'] ) ?: $term->name;
} elseif ( isset( $item->url ) ) {
$item_array['menu-item-url'] = ( 'http' == substr( $item->url, 0, 4 ) ) ? esc_url( $item->url ) : home_url( $item->url );
$item_array['menu-item-url'] = $item->url;
$item_array['menu-item-title'] = ( $item_array['menu-item-title'] ) ?: $item->url;
} else {
continue;
Expand Down Expand Up @@ -246,10 +239,9 @@ public function export_json( $file, $mode = 'relative' ) {
$export_item['url'] = $item->url;
break;
case 'post_type':
if ( 'page' == $item->object ) {
$page = get_post( $item->object_id );
$export_item['page'] = $page->post_name;
}
$page = get_post( $item->object_id );
$export_item['page'] = $page->post_name;
$export_item['object'] = $item->object;
break;
case 'taxonomy':
$term = get_term( $item->object_id, $item->object );
Expand Down