Fix meson build configuration for GAP #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update gapversion script to use .F90 file extensions instead of .f95 - Add -lgomp link argument to meson.build for OpenMP support These changes fix build issues when building GAP with the meson build system. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed format descriptor in gap_fit_module.F90 line 1603 to be compatible
with gfortran 15.1.0. Changed from:
write(gp_label,'("GAP_"7(i0,"_")i0)')
to:
write(gp_label,'("GAP_",7(i0,"_"),i0)')
This adds the required comma separators between format descriptors, which
gfortran 15.1.0 enforces more strictly. The generated unique IDs remain
identical in format.
Error fixed:
Fortran runtime error: Missing comma between descriptors
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background
These changes fix build issues when building GAP with the meson build system. The gapversion script was looking for .f95 files which have been renamed to .F90, and the OpenMP library was not being linked correctly.
Test plan
🤖 Generated with Claude Code