Skip to content

Conversation

@ElliottKasoar
Copy link
Contributor

As discussed with @stenczelt, adds ruff code formatter/linter, which is now used within a pre-commit, and tested through the CI.

For review purposes, I'd suggest looking at each commit in isolation, due to the large number of changes applied. Essentially, these involve:

  1. Adding pre-commit dependencies, and rules for ruff to apply
  2. Creating the pre-commit file to be run
  3. Adding the pre-commit to CI tests
  4. Applying the non-ruff pre-commit hooks to all files (white space formatting etc.)
  5. Applying ruff format and ruff check --fix changes to all files
  6. Applying ruff check --fix --unsafe-fixes and manual fixes to all files
  7. Reapplying ruff format to code added in Fix data model #117

@stenczelt stenczelt self-requested a review March 1, 2025 09:21
Copy link
Member

@stenczelt stenczelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@stenczelt stenczelt merged commit 84366f9 into libAtoms:master Mar 1, 2025
5 checks passed
@ElliottKasoar ElliottKasoar deleted the add-ruff branch March 1, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants