Django1.4 with USE_TZ=True needs timezone aware datetimes#2
Open
magopian wants to merge 2 commits intoliberation:masterfrom
Open
Django1.4 with USE_TZ=True needs timezone aware datetimes#2magopian wants to merge 2 commits intoliberation:masterfrom
magopian wants to merge 2 commits intoliberation:masterfrom
Conversation
Author
|
Second commit "uglifies" the code, but makes it compatible with 1.3.1 AND 1.4 |
There was a problem hiding this comment.
What about something like:
try:
from django.utils.timezone import utc
except ImportError:
utc = None
return datetime.datetime(year=2008, month=7, day=1, tzinfo=utc)I mean:
- same call to datetime.datetime()
- ability to move the try/import/except to the beginning of the module ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using Django1.4 and USE_TZ = True, the datetime objects used need to be timezone aware.
Using the django.utils.timezone helpers makes it usable wether the USE_TZ setting is set to True or False.