Adding verbose flag to 'save_' functions#1
Open
weslleyspereira wants to merge 1 commit intolibigl:masterfrom
Open
Adding verbose flag to 'save_' functions#1weslleyspereira wants to merge 1 commit intolibigl:masterfrom
weslleyspereira wants to merge 1 commit intolibigl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
First of all, thank you for this helpful library.
I am using this library in a C++ project. Since the code runs in multiple threads, the printf's generated by the "save_" functions cause the output to largely increase in size. Discarding these outputs without changing the code is too difficult since the threads runs independently and share the STDOUT.
So, I propose the addition of verbose flags to the "save_" functions to control the output.
The default behavior has been preserved.
Sds.
Weslley.