Ensure libirecovery API compatibility for current release #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapts to API changes in libirecovery where the `irecv_init()` function may no longer be available or required. Introduces a configure check to determine the presence of `irecv_init()`. `IRECV_MAYBE_INIT()`, is then used to conditionally call `irecv_init()` only if it exists, preventing build failures and ensuring proper behaviour across different versions of libirecovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You will need to give this its own branch most likely. The aur package has started failing because the libirecovery aur package that is available is too new and causes version 1.0.0 to fail. Whilst I understand that a new release is in development and you may not wish to make a new release yet, I think at the very least this is a good compromise, it should work with old libirecovery versions, just like the current version, as well as newer versions of libirecovery. This should help prevent complaints that the current version is 'broken' and 'doesn't build' as more distros start to use the newer libirecovery versions, without harming other distros that choose to keep using older libirecovery versions
Adapts to API changes in libirecovery where the
irecv_init()function may no longer be available or required.Introduces a configure check to determine the presence of
irecv_init().IRECV_MAYBE_INIT(), is then used to conditionally callirecv_init()only if it exists, preventing build failures and ensuring proper behaviour across different versions of libirecovery.