Skip to content

Conversation

@jtippet
Copy link

@jtippet jtippet commented Feb 25, 2020

The HTML report's Javascript incorrectly assumes that the benchmarks in each run are sorted in the same order. That's not the case (maybe it should be?). Instead, you can often have something like this:

var data = { runs: [
    { benchmarks: [ { name: 'a', mean: 1 }, { name: 'b', mean: 2 } ] },
    { benchmarks: [ { name: 'b', mean: 3 }, { name: 'a', mean: 4 } ] },
]};

In the above example, the summary plot would assume that the first benchmark is named 'a', and it would draw a line for series 'a' connecting points [1, 3]. It should instead draw a line connecting points [1, 4].

This change updates the javascript to search all the runs in the benchmark for one with the target name.

Fixes #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML report shows wrong data with multiple param values

1 participant