feat(swarm): expose ConnectionId and add conn duration metric#3927
Merged
mergify[bot] merged 10 commits intolibp2p:masterfrom May 17, 2023
Merged
feat(swarm): expose ConnectionId and add conn duration metric#3927mergify[bot] merged 10 commits intolibp2p:masterfrom
ConnectionId and add conn duration metric#3927mergify[bot] merged 10 commits intolibp2p:masterfrom
Conversation
…metric - Exposes the `ConnectionId` in the various `SwarmEvent` variants. - Tracks connection duration in `libp2p-metrics::swarm`.
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Direction looks good.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Contributor
|
This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏 |
thomaseizinger
approved these changes
May 16, 2023
misc/metrics/src/swarm.rs
Outdated
| struct ConnectionClosedLabels { | ||
| role: Role, | ||
| protocols: String, | ||
| // TODO: Should be Option<ConnectionError>. Needs https://github.com/prometheus/client_rust/pull/137 |
Contributor
There was a problem hiding this comment.
Do we wait for this before merging here?
Member
Author
There was a problem hiding this comment.
Oversight. Fixed with 9578315. Thanks for the catch Thomas!
mxinden
changed the title
ConnectionId thus enable connection duration metricConnectionId and add conn duration metric
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Mar 8, 2024
- Exposes the `ConnectionId` in the various `SwarmEvent` variants. - Tracks connection duration in `libp2p-metrics::swarm`. Pull-Request: libp2p#3927.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConnectionIdin the variousSwarmEventvariants.libp2p-metrics::swarm.Notes & open questions
Draft as it depends on prometheus/client_rust#137.Change checklist