docs: fix ProviderPhase documentation contradiction#6201
Open
Lil-Duckling-22 wants to merge 1 commit intolibp2p:masterfrom
Open
docs: fix ProviderPhase documentation contradiction#6201Lil-Duckling-22 wants to merge 1 commit intolibp2p:masterfrom
Lil-Duckling-22 wants to merge 1 commit intolibp2p:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The documentation for ProviderPhase incorrectly stated that "a provider has been chosen but not yet specified", which contradicts the type signature SwarmBuilder<NoProviderSpecified, ProviderPhase>.
Updated the docs to accurately reflect that the identity has been set, but the runtime provider selection is still pending.