Open
Conversation
hanabi1224
force-pushed
the
smart-dialing
branch
2 times, most recently
from
7eb74b9 to
3a39fee
Compare
hanabi1224
force-pushed
the
smart-dialing
branch
from
3a39fee to
85bc539
Compare
| const PUBLIC_OTHER_DELAY: Duration = Duration::from_millis(1000); | ||
| const PRIVATE_OTHER_DELAY: Duration = Duration::from_millis(100); | ||
|
|
||
| pub(crate) type DialRanker = fn(Vec<Multiaddr>) -> Vec<(Multiaddr, Option<Duration>)>; |
Contributor
There was a problem hiding this comment.
Should we consider using a closure here instead of a fn?
It would preserve the current behaviour and also allow dial rankings to incorporate runtime state if needed. Similar patterns are used for Swarm and SwarmBuilder.
Contributor
Author
There was a problem hiding this comment.
Good idea! Changed DailRanker to a closure trait object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to port smart dialing logic from
go-libp2phttps://github.com/libp2p/go-libp2p/blob/v0.45.0/p2p/net/swarm/dial_ranker.go
libp2p/go-libp2p#2260
Notes & open questions
Change checklist