feat(relay): remove deprecated error events in favor of warn! logs#6248
feat(relay): remove deprecated error events in favor of warn! logs#6248asmit27rai wants to merge 1 commit intolibp2p:masterfrom
Conversation
Remove the following deprecated relay server events and log them internally at warn level instead: - ReservationReqAcceptFailed - ReservationReqDenyFailed - CircuitReqDenyFailed - CircuitReqAcceptFailed - CircuitReqOutboundConnectFailed These events represent protocol violations or connection failures that don't require programmatic handling. Logging them at warn level allows relay operators to monitor for potential issues without cluttering the event API. Closes libp2p#4757
|
@thomaseizinger Happy to address any feedback or make adjustments. Let me know if you'd like me to change anything! |
I no longer maintain this, will delegate to @jxs. |
|
@jxs Please review this PR... |
|
@asmit27rai thank you for your PR! There is already PR that does the same #6094. But, as written in #6094 (review), I would rather keep the events anyway. We've had quite a few issue and PR in the past from users that wanted us to expose more events rather than less. |
Hi, thanks for this, but it's as Elena says. Do you have a personal need for this? I.e are you using relay in production and this hits a pain point? |
I wonder if we should remove the deprecation notice to prevent confusion about this. Thoughts? |
Yes make sense IMO. I just wanted to wait first if you @dariusc93 @jxs agree. I'll create a PR. |
5 participants
Description
Resolves #4757
This PR removes the deprecated relay server events and replaces them with
tracing::warn!logs:ReservationReqAcceptFailedReservationReqDenyFailedCircuitReqDenyFailedCircuitReqAcceptFailedCircuitReqOutboundConnectFailedChanges
Eventvariants fromrelay::Eventtracing::warn!logs including peer IDs and error detailslibp2p-metricsto remove corresponding event type tracking