Open
Conversation
https://rust-lang.github.io/rust-clippy/beta/index.html#result_large_err The `Result` is consumed immediately below so the large error variant is never propagated across stack frames.
…elemetry-otlp The opentelemetry-jaeger crate is deprecated https://rustsec.org/advisories/RUSTSEC-2025-0123
- Remove deprecated 'version' field (obsolete in Compose V2) - Quote port mappings to follow YAML best practices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/libp2p/rust-libp2p/actions/runs/21696896538/job/62568845676?pr=6264
ref: result_large_err
Allowed
result_large_errsince theResultreturned by the closure is consumed immediately, so the large error variant is never propagated across stack frames.Also, I updated the
autonatv2example to fix a cargo-deny error caused by the deprecation of theopentelemetry-jaegercrate. It has been migrated toopentelemetry-otlp. And I verified that the example works as expected (see the screenshot below).Notes & open questions
Change checklist