experiment: alloc uninitialised buffer for incoming decrypted data#337
Draft
achingbrain wants to merge 2 commits intomasterfrom
Draft
experiment: alloc uninitialised buffer for incoming decrypted data#337achingbrain wants to merge 2 commits intomasterfrom
achingbrain wants to merge 2 commits intomasterfrom
Conversation
`@chainsafe/noise` has an optimisation where the buffer containing incoming encrypted data is reused for the decrypted data to avoid allocing a new buffer. This data arrives as a `Uint8ArrayList` so where it spans more than one buffer it can involve copying the data first, only to then overwrite it. This experiment tests: - v1.0: default behaviour - v1.0-noise-alloc: use alloc unsafe to allocate a new unitialised buffer - v1.0-noise-alloc-smart: only alloc unsafe if the list contains more than one buffer
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chainsafe/noisehas an optimisation where the buffer containing incoming encrypted data is reused for the decrypted data to avoid allocing a new buffer.This data arrives as a
Uint8ArrayListso where it spans more than one buffer it can involve copying the data first, only to then overwrite it.This experiment tests: