Open
Conversation
This was referenced Jul 18, 2024
MarcoPolo
force-pushed
the
marco/go-holepunch-interop
branch
from
109ffd1 to
4afed36
Compare
1. Don't observe the relay's address. 2. Fix the roles when doing a tcp sim-connect
Contributor
Author
|
The two issues we fixed in go-libp2p that let us pass these tests:
|
Contributor
Author
|
We need to release those fixes before we can merge this. |
Signed-off-by: Dave Grantham <dwg@linuxprogrammer.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't interop in all cases with rust!
Part of it is this issue: libp2p/rust-libp2p#5466
And part of it is still unknown to me and needs more debugging. I wanted to open this to share my work
Thanks @thomaseizinger for making this! works great.
Future versions will have this impl live in go-libp2p. For now though it's easier for debugging if this is here.