perf: gracefully parse ResultValue from output#661
Merged
p-shahi merged 2 commits intolibp2p:masterfrom Jun 10, 2025
Merged
Conversation
cd18890 to
25ba45e
Compare
p-shahi
approved these changes
Jun 10, 2025
codemaestro64
pushed a commit
to codemaestro64/test-plans
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when running client, parsing
ResultValuefrom ostdout lines can throw exception if line could not be parsed.in order to help developers, new console.error was added to display line that caused error.
also, error will be swallowed, which will give more robustness in running client as it will tolerated non json lines in the output.
PR inspired by
#658 (comment)