This repository was archived by the owner on Feb 3, 2025. It is now read-only.
fix(Structures): GuildIntegration missing optional#39
Open
SiroTM wants to merge 2 commits intolibraryofcode:betafrom
Open
fix(Structures): GuildIntegration missing optional#39SiroTM wants to merge 2 commits intolibraryofcode:betafrom
SiroTM wants to merge 2 commits intolibraryofcode:betafrom
Conversation
bsian03
suggested changes
Jun 9, 2021
Member
bsian03
left a comment
bsian03
left a comment
There was a problem hiding this comment.
I'd rather keeping the types as they are but default export a union of GuildIntegration and BotIntegration in this case
Collaborator
|
lol uk vs us naming. |
Khaaz
changed the title
Khaaz
added
repo: structures
semver: patch
t: documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following properties optional:
enable_emoticons,expire_behavior,revoked,role_id,subscriber_count,syncinganduser.This also renames
IntegrationExpireBehaviourtoIntegrationExpireBehavior.