Update Version.h and add NiNode.h #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarthSidious666
commented
Nov 28, 2025
Contributor
Author
DarthSidious666
left a comment
DarthSidious666
left a comment
There was a problem hiding this comment.
I apologise in advance if the pull request is a bit messy, been a long time since I used github this way.
Version.h update is pretty straightforward.
NiNode.h probably needs some more work on it (I'm quite new at this side of RE and more experienced people will be better than I am at this sort of thing).
qudix
reviewed
Nov 28, 2025
include/RE/N/NiNode.h
Outdated
| class NiNode : public NiAVObject | ||
| { | ||
| public: | ||
| // Virtual destructor / vtable are present (attributes = 0x40 in RTTI). |
Contributor
There was a problem hiding this comment.
Please remove all of these comments and follow the general style of the rest of the codebase. We put vtable indexes and member offsets instead.
Contributor
Author
There was a problem hiding this comment.
OK, no problem.
DarthSidious666
commented
Dec 1, 2025
Contributor
Author
DarthSidious666
left a comment
DarthSidious666
left a comment
There was a problem hiding this comment.
As requested changed the file and added offsets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Version.h file in SFSE to the latest SFSE and Starfield Runtimes.