Skip to content

Fix for multiple option #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzalocelina wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Fix for multiple option #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d5d04b9
Fix for multiple option
gonzalocelina Dec 13, 2016
cd129ea
Modification of if
gonzalocelina Dec 13, 2016
7597269
Fix required set
t-veron Dec 15, 2016
41b643d
Merge pull request #19 from t-veron/master
lifo101 Dec 28, 2016
393bc27
Update composer.json
gonzalocelina Nov 13, 2017
3fd3529
removed symfony/symfony requirement so installs will work with symfon…
lifo101 Dec 13, 2018
4164d92
Fix for multiple option
gonzalocelina Dec 13, 2016
c2d8137
Modification of if
gonzalocelina Dec 13, 2016
215eb17
Merge con master
gonzalocelina May 10, 2019
b5e26fb
gitignore
gonzalocelina May 10, 2019
36ef9c8
Ahora
gonzalocelina May 10, 2019
696ada5
Nueva forma de poner templates en SF4
gonzalocelina May 13, 2019
ae9e24c
Vuelta por las dudas
gonzalocelina May 13, 2019
becdbea
Typo
gonzalocelina May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
.idea
/.idea
2 changes: 1 addition & 1 deletion DependencyInjection/LifoTypeaheadExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ protected function configureAsseticBundle(ContainerBuilder $container, array $co
protected function configureTwigBundle(ContainerBuilder $container, array $config)
{
if ($container->hasExtension('twig')) {
$resources = array('LifoTypeaheadBundle:Form:typeahead.html.twig');
$resources = array('@LifoTypeahead\Form\typeahead.html.twig');
if (Kernel::VERSION_ID >= '20600') {
$container->prependExtensionConfig('twig', array('form_themes' => $resources));
} else {
Expand Down
4 changes: 2 additions & 2 deletions Resources/views/Form/typeahead.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% block entity_typeahead_widget %}
{% spaceless %}
{% set required, main_full_name, main_id, main_value, main_attr = false, full_name, id, value, attr %}
{% set main_full_name, main_id, main_value, main_attr = full_name, id, value, attr %}

{# create visible autocomplete input #}
{% set id = main_id ~ '_text' %}
Expand Down Expand Up @@ -56,7 +56,7 @@

{% block entity_typeahead_list_widget %}
{% spaceless %}
{% if simple %}
{% if simple or child == null %}
{% set _id, _value, _render = child, child, child %}
{% else %}
{% set _id, _value, _render = child.id, attribute(child, property ?: 'id'), attribute(child, render) %}
Copy link

@ahoulgrave ahoulgrave Dec 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here child var can be null (L31). cannot call any property without asking if null.

Expand Down
3 changes: 0 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
"email": "lifo2013@gmail.com"
}
],
"require": {
"symfony/symfony": "^2.6 || ^3.0"
},
"suggest": {
"twbs/bootstrap": "Bootstrap framework",
"mopa/bootstrap-bundle": "Bundle to automatically enable Bootstrap styles for Symfony"
Expand Down