-
Notifications
You must be signed in to change notification settings - Fork 112
gomod: update loop client to v0.31.7-beta #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hieblmi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to resolve a reported CI job failure by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the loop client dependency from v0.31.6-beta to v0.31.7-beta. The change, intended to fix a CI job, is simple and correctly applied to go.mod and go.sum. My review includes one suggestion to maintain project documentation standards: please add an entry for this version bump in the release notes, as is customary for this repository.
| github.com/lightninglabs/lightning-terminal/perms v1.0.1 | ||
| github.com/lightninglabs/lndclient v0.20.0-6 | ||
| github.com/lightninglabs/loop v0.31.6-beta | ||
| github.com/lightninglabs/loop v0.31.7-beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This dependency update should be documented in the release notes to maintain a clear history of changes. It's a standard practice in this repository to record version bumps. Please add a note for this update to v0.31.7-beta in the appropriate release notes file. For reference, here is a similar entry from docs/release-notes/release-notes-0.16.0.md:
### Loop
* [PR](https://github.com/lightninglabs/lightning-terminal/pull/1173): Bump:
`loop@v0.31.6-beta`, `loop/looprpc@v1.0.12`, `loop/swapserverrpc v1.0.19`.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
ViktorT-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, except that this also needs release notes :).
As communicated offline, this won't really resolve the loop CI jobs, but as this is good to get into litd either way, I'm ok with merging this if we add release notes for it :)!
| * [PR](https://github.com/lightninglabs/lightning-terminal/pull/1191): Bump: | ||
| `loop@v0.31.7-beta`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, litd v0.16.0-alpha was recently shipped, so the version you should add these release notes for is v0.16.1.
Those do not exist yet, so you'd need to add a file for them :)
ffranr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once Viktor's comment is addressed re 0.16.1
ViktorT-11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! LGTM
This PR is an attempt to fix loop CI job: https://github.com/lightninglabs/loop/actions/runs/20235105376/job/58090029559?pr=1059