deps: update lnc-core to v0.3.5-alpha #139
Conversation
|
It's fine for CI to fail right now since the new The more important update that this PR should include is to update the URL to the new LNC wasm file. See #122 for reference. |
|
Great @jamaljsr I've updated that lnc-web PR to contain the new WASM. I've tested this |
jbrill
force-pushed
the
update-deps-12-15-25
branch
from
bfe2b8e to
48cc963
Compare
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
Nice, looks good 🚀!
Similar to #122, I think you want to include a last commit to this PR that bumps the version as well. We can do that in a separate PR though if needed, but I think it makes sense to do it in this PR.
Huh I think this should be the same structure as #122 ? Were you looking at an old state of this PR by chance? Might be missing something! |
| { | ||
| "name": "@lightninglabs/lnc-web", | ||
| "version": "0.3.4-alpha", | ||
| "version": "0.3.5-alpha", |
There was a problem hiding this comment.
Ah sorry, missed that and what I mean that this specific change should be in a separate commit that bumps the version only. We want that commit to be the last commit before the merge commit, as we don't want any additional changes to have happened in the commit tree after the version has been bumped. This is currently placed as the second last commit.
Hope that makes it more clear :)!
There was a problem hiding this comment.
That makes sense! Thanks for the clarification!
I've addressed this PR with that structure -- I hope it looks ok now 🙏
jbrill
force-pushed
the
update-deps-12-15-25
branch
from
48cc963 to
29f0a5b
Compare
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
Nice, thanks for the change 🎉. LGTM 🔥
Updates
lnc-webto use the newlnc-corev0.3.5-alphabindings.