Skip to content

Conversation

@jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Jan 8, 2026

This is follow-up to #140 which didn't fully enable NPM trusted publishing because the version of the npm CLI used in our CI workflow wasn't updated to a version that supported this new publishing feature.

I have tested this change in a branch by publishing a pre-release tag to NPM (which I've already deprecated) and it worked.
See: https://github.com/lightninglabs/lnc-web/actions/runs/20822098530

@jamaljsr jamaljsr requested review from ViktorT-11 and jbrill January 8, 2026 15:51
@jamaljsr jamaljsr self-assigned this Jan 8, 2026
Copy link
Collaborator

@ViktorT-11 ViktorT-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jbrill jbrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamaljsr jamaljsr merged commit b9035ab into main Jan 8, 2026
6 checks passed
@jamaljsr jamaljsr deleted the npm-trusted-publishing branch January 8, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants