-
Notifications
You must be signed in to change notification settings - Fork 68
LCORE-1216: Bump up to llama-stack 0.4.2 #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,6 @@ | |
| from llama_stack_client import ( | ||
| APIConnectionError, | ||
| APIStatusError, | ||
| NOT_GIVEN, | ||
| ) | ||
| from sqlalchemy.exc import SQLAlchemyError | ||
|
|
||
|
|
@@ -332,10 +331,10 @@ async def get_conversation_endpoint_handler( | |
| # Use Conversations API to retrieve conversation items | ||
| conversation_items_response = await client.conversations.items.list( | ||
| conversation_id=llama_stack_conv_id, | ||
| after=NOT_GIVEN, | ||
| include=NOT_GIVEN, | ||
| limit=NOT_GIVEN, | ||
| order=NOT_GIVEN, | ||
| after=None, | ||
| include=None, | ||
| limit=None, | ||
| order=None, | ||
|
Comment on lines
+334
to
+337
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # First, let's see the file and the specific lines in question
cat -n src/app/endpoints/conversations_v3.py | sed -n '320,350p'Repository: lightspeed-core/lightspeed-stack Length of output: 1319 🏁 Script executed: # Check if NOT_GIVEN is used elsewhere in this file
rg -n "NOT_GIVEN" src/app/endpoints/conversations_v3.pyRepository: lightspeed-core/lightspeed-stack Length of output: 58 🏁 Script executed: # Search for NOT_GIVEN usage patterns across the codebase
rg -n "NOT_GIVEN" --type py | head -20Repository: lightspeed-core/lightspeed-stack Length of output: 58 🏁 Script executed: # Look for llama-stack-client imports and usage patterns
rg -n "from llama_stack_client" --type py | head -10Repository: lightspeed-core/lightspeed-stack Length of output: 1132 🏁 Script executed: # Check if there's a requirements or dependencies file
fd -e txt -e toml -e cfg -e lock | grep -E "(requirements|pyproject|setup|lock)"Repository: lightspeed-core/lightspeed-stack Length of output: 270 🏁 Script executed: # Check pyproject.toml for llama-stack-client version
cat pyproject.toml | grep -A 5 -B 5 "llama"Repository: lightspeed-core/lightspeed-stack Length of output: 1265 🏁 Script executed: # Broader search for NOT_GIVEN across all files
rg -n "NOT_GIVEN" --type pyRepository: lightspeed-core/lightspeed-stack Length of output: 58 🏁 Script executed: # Check if there are any test files for conversations endpoint to see expected patterns
find . -name "*conversations*" -type f | head -20Repository: lightspeed-core/lightspeed-stack Length of output: 543 🌐 Web query:
💡 Result: For “
|
||
| ) | ||
| items = ( | ||
| conversation_items_response.data | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure there are no other dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we resolve this comment?