Skip to content

Conversation

@raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Jan 28, 2026

Description

use RHAI base image, that comes with dependant libraries such as openMPI already installed.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Enhanced build system configurability by adding support for customizable runtime base images and package manager commands.
    • Introduced new build arguments file parameter to pipeline configurations, enabling flexible build-time configuration management.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Haoyu Sun <hasun@redhat.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

Walkthrough

This pull request introduces build-time configurability for container runtime settings. A new build-args-file parameter flows through Tekton pipelines into the Containerfile, enabling dynamic configuration of runtime base images and package manager commands via build arguments.

Changes

Cohort / File(s) Summary
Tekton Pipeline Configuration
.tekton/lightspeed-stack-pull-request.yaml, .tekton/lightspeed-stack-push.yaml
Added build-args-file parameter (value: build-args-konflux.conf) to both pipeline definitions. Parameter is wired into the build matrix as BUILD_ARGS_FILE to supply build arguments to the build task.
Build Configuration
build-args-konflux.conf
Added default values for two new runtime configuration variables: RUNTIME_BASE_IMAGE (registry.redhat.io/rhai/base-image-cpu-rhel9:3.2) and RUNTIME_DNF_COMMAND (dnf).
Container Image Definition
Containerfile
Introduced new build-time arguments: RUNTIME_BASE_IMAGE, RUNTIME_DNF_COMMAND, and LSC_SOURCE_DIR. Replaced hard-coded final base image reference with ${RUNTIME_BASE_IMAGE}. Replaced hard-coded microdnf invocation with ${RUNTIME_DNF_COMMAND}. Added chown step for llama directories in final image.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • radofuchs
  • tisnik
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'konflux: use RHAI base image' directly describes the main change—replacing the Konflux base image with RHAI base image, which aligns with the PR objectives and all file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
Containerfile (1)

57-85: Add ARG RUNTIME_DNF_COMMAND to the final stage to fix empty variable expansion.

ARGs declared before the first FROM (line 3) have global scope but are not automatically available inside build stages. At line 85, ${RUNTIME_DNF_COMMAND} expands to empty, causing the command to fail with install: invalid option -- 'y'. Re-declare the ARG in the final stage.

Fix
 FROM ${RUNTIME_BASE_IMAGE}
+ARG RUNTIME_DNF_COMMAND
 ARG APP_ROOT=/app-root
 WORKDIR /app-root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant