Skip to content

Hos 26349 rebase on main #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ls-denys-ryzhkov merged 5 commits into from
Nov 21, 2024
Merged

Hos 26349 rebase on main #1

ls-denys-ryzhkov merged 5 commits into from
Nov 21, 2024

Conversation

@ls-denys-ryzhkov
Copy link

@ls-denys-ryzhkov ls-denys-ryzhkov commented Nov 19, 2024 •
edited
Loading

Pull Request Description

Rebased old branch lightspeed-fixes on main in order to have an SPM support. This fork is used in CorePlatform in LUKit to download images.

Deleted the commit as now not relevant:
Message: HOS-9304 Fixed a known oops in SDWebImage’s umbrella header.
Hash: 49563e8
Author: Olivier Verhoogen olivier.verhoogen@lightspeedhq.com
Date: 18 Nov 2024 at 16:55

Decided to make a rebase as it is easier to check the exact commit and resolve conflicts only for it.

chucks and others added 5 commits November 19, 2024 11:06
@chucks @ls-denys-ryzhkov
LI-7258 - fix ordering of Copy Headers build phase for all framework …
0ec941a 
…targes
@ls-matthew-garden @ls-denys-ryzhkov
LI-7420 Update project to Xcode 10.1
c1cc93c
@ls-philippe-casgrain @ls-denys-ryzhkov
HOS-16381 Update SDWebImage to support custom certificates
4f05630 
When you provide an array of certificates (in binary format), simply
set the SDWebImageDownloaderUseSpecifiedSSLCertificates option to let
SDWebImage perform a trust chain evaluation when downloading images.

You can use this as a safer alternative to SDWebImageDownloaderAllowInvalidSSLCertificates.
@ls-tim-viaene @ls-denys-ryzhkov
HOS-20763 Update project to Xcode 10.3
38d9da4
@ls-bertrand-landry-hetu @ls-denys-ryzhkov
HOS-25702 Bumped deployment target
60de82f
@ls-denys-ryzhkov ls-denys-ryzhkov marked this pull request as draft November 19, 2024 10:39
@ls-denys-ryzhkov ls-denys-ryzhkov marked this pull request as ready for review November 19, 2024 17:58
ls-philippe-casgrain
ls-philippe-casgrain approved these changes Nov 19, 2024
View reviewed changes
Copy link

@ls-philippe-casgrain ls-philippe-casgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it build with Xcode 15?

@ls-denys-ryzhkov ls-denys-ryzhkov changed the base branch from lightspeed-fixes-spm to lightspeed-fixes November 20, 2024 18:50
@ls-denys-ryzhkov ls-denys-ryzhkov changed the base branch from lightspeed-fixes to lightspeed-fixes-spm November 20, 2024 18:50
@ls-denys-ryzhkov
Copy link
Author

ls-denys-ryzhkov commented Nov 20, 2024

@ls-philippe-casgrain it is running on Xcode 15.2
As this is not our internal repo that we hold, but a fork and I've just rebased the changes, decided not to dive deep into problems with pipelines. Here's the updated statuses:

  • unit test for ios are flaky, now they are green
  • there is only one test failed for macOS, but it is succeeded locally
  • Cocoapods are not related to us at all.

is this PR okay for you at this state or should I go for it and resolve the issues?

@lisional
Copy link

lisional commented Nov 20, 2024 •
edited
Loading

iOS tests are all passing locally for me, Xcode 15.1 ✅
I think it's good as it is, and it will actually be helpful for CorePlatform! I tried to move to SPM for SDWebImage, and I was missing a couple of functions I see you added in this PR.

Are you planning on opening a PR to switch to SPM in CorePlatform?
Edit: just saw your PR, great! 🥳

I'm about to open one to switch Base to SPM in CorePlatform

@ls-denys-ryzhkov ls-denys-ryzhkov merged commit 60de82f into lightspeed-fixes-spm Nov 21, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lisional lisional lisional approved these changes

@ls-philippe-casgrain ls-philippe-casgrain ls-philippe-casgrain approved these changes

@ls-bertrand-landry-hetu ls-bertrand-landry-hetu Awaiting requested review from ls-bertrand-landry-hetu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ls-denys-ryzhkov @lisional @ls-philippe-casgrain @chucks @ls-matthew-garden @ls-tim-viaene @ls-bertrand-landry-hetu