Skip to content

Reconnect smtp_server instance if not connected #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
broper2 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reconnect smtp_server instance if not connected #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion notifiers/providers/email.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def _send_notification(self, data: dict) -> Response:
errors = None
try:
configuration = self._get_configuration(data)
if not self.configuration or not self.smtp_server or self.configuration != configuration:
if not self.configuration or not self._is_smtp_connection_alive(self.smtp_server) or self.configuration != configuration:
self._connect_to_server(data)
email = self._build_email(data)
if data.get("attachments"):
Expand All @@ -193,3 +193,13 @@ def _send_notification(self, data: dict) -> Response:
) as e:
errors = [str(e)]
return self.create_response(data, errors=errors)

@staticmethod
def _is_smtp_connection_alive(smtp_server: smtplib.SMTP):
if smtp_server is None:
return False
try:
status = smtp_server.noop()[0]
return status == 250
except Exception:
return False