Updated the memory provider to act like a very basic queue #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andling Make sure we handle non-errors
…urning into a nightmare
arbarlow
reviewed
Jan 7, 2022
Contributor
arbarlow
left a comment
arbarlow
left a comment
There was a problem hiding this comment.
Thanks, looks good, could you do a bit of tidying and I'll be glad to accept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the memory provider will just loop through a map of messages once when there's a new Subscriber. This expands the MemoryProvider out, making it a little more consistent with the code style of the others (a constructor, actually doing stuff in the shutdown, etc), and adds some more queue-like functionality using some channels and goroutines.