Skip to content

Conversation

@dfrg
Copy link
Contributor

@dfrg dfrg commented Mar 2, 2023

Changes the SVG writer to emit commas between coordinate components and spaces between coordinates and commands.

Requested by @rsheeter in this comment.

dfrg added 2 commits March 2, 2023 17:10
Changes the SVG writer to emit commas between coordinate components and spaces between coordinates and commands.
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra space byte pains me slightly, but the previous state wasn't an optimized packer (it could do relative coords, special cases, limit precision, etc).

@dfrg
Copy link
Contributor Author

dfrg commented Mar 3, 2023

Might be worth adding a to_svg_packed method in the future that does all of these optimizations.

@dfrg dfrg merged commit 343fc5c into linebender:master Mar 3, 2023
@dfrg dfrg deleted the write-svg-format branch March 3, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants