-
Notifications
You must be signed in to change notification settings - Fork 62
Add text-drawing benchmarks #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This applies to tests as well as benchmarks: I think collocating the |
OK, what's the deal with this? I haven't been able to find any relevant Zulip threads about what on earth is actually in-scope for I guess I just don't understand the motivation for why we want to move |
I'm not sure if there is full consensus on this yet, but my vision / understanding is that the scope is:
It therefore serves as a replacement for the "scaling" and "rasterizing" functionality in I therefore think that the crate definitely shouldn't be Parley branded (have "parley" in the name). And I expect it's development to be more closely aligned with Vello and a rendering abstractions. But to be fair, neither of those technically preclude it from staying in this repo.
Yes, but it could quite easily be the crates.io version. |
conor-93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these.
I think collocating the parley_draw tests/benchmarks with the regular parley tests/benchmarks is a bad idea
For now, I think for now having parley_draw tests in their own file is a sufficient degree of separation. I agree that will likely need to change in the future, as we get a clearer picture of the future of parley_draw.
If we move it into its own repository, why can't we just move these benchmarks there too?
It'd be good to have these benchmarks now though, yes. I don't think moving them will be that hard (and will follow naturally from any separation that may later happen).
ca56705 to
ea79748
Compare
Adds a few different benchmark variants, to test the performance impact of underline drawing and caching.
For some reason, on my machine (Linux) I need to pass the
-p(parallel) flag to tango when performing a comparison. Without it, the "new" code always comes back as ridiculously faster, even when it's not been changed at all. I can't find any information on why this would be.