Fontique: Additional methods for fontdb parity
#540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
added
enhancement
Collaborator
|
Generally LGTM except that reloading system fonts should probably clear caches or you’ll end up with stale family ids. If reloading isn’t required for fontdb parity then we should defer that to future work. |
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
nicoburns
force-pushed
the
resvg-support
branch
from
5703872 to
bf17d82
Compare
Signed-off-by: Nico Burns <nico@nicoburns.com>
Signed-off-by: Nico Burns <nico@nicoburns.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional methods with the aim of making
fontiquea suitable replacement forfontdbin resvg:load_system_fontsloads system fonts into aCollectionthat did not specify loading them at creation timeload_fonts_from_pathsloads all fonts from the specified directory(s)