Skip to content

Fix Mix bytemuck const-test coverage #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DJMcNab merged 1 commit into from
Jan 26, 2026
Merged

Fix Mix bytemuck const-test coverage #160

DJMcNab merged 1 commit into from
Jan 26, 2026

Conversation

@no-materials
Copy link
Contributor

@no-materials no-materials commented Jan 26, 2026

This fixes a (probably) copy/paste error in the bytemuck const-eval sanity check so the Mix enum is actually validated. The compile-time contiguous-range check now iterates over Mix::MAX_VALUE and reads Mix values, restoring coverage of the bytemuck::Contiguous impl.

DJMcNab
DJMcNab approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DJMcNab DJMcNab added this pull request to the merge queue Jan 26, 2026
Merged via the queue into linebender:main with commit a041cd4 Jan 26, 2026
27 of 30 checks passed
@no-materials no-materials deleted the fix/mix-bytemuck-const-test branch January 27, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@no-materials @waywardmonkeys @DJMcNab