imaging_model: introduce initial clip-focused model types #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
commented
Feb 11, 2026
|
|
||
| /// Conservative axis-aligned bounds of this geometry. | ||
| /// | ||
| /// Returns `None` if the geometry bounds are non-finite. |
Collaborator
Author
There was a problem hiding this comment.
Is this a reasonable guarantee to make?
| return None; | ||
| } | ||
|
|
||
| // Conservative outset to account for width, caps, and miter joins. |
Collaborator
Author
There was a problem hiding this comment.
Is the fact that this isn't accurate a reason to not do it? Should we drop Clip::bounds because of this? But we do call it out in the doc comment. But maybe we should call the function conservative_bounds instead?
| Fill { | ||
| /// Transform applied to the clip shape. | ||
| /// | ||
| /// This does not affect subsequent draws; it only affects how the clip shape is interpreted. |
Collaborator
Author
There was a problem hiding this comment.
At some point, we should identify the semantics of this transform: coordinate space, when it is applied, etc.
waywardmonkeys
force-pushed
the
initial-imaging_model
branch
from
313bb12 to
aed02d7
Compare
Introduce a first draft of the `imaging_model` crate with clip-focused model types. The goal is to establish a small, explicit core model that we can evolve as we define the imaging model and move our renderers to using it.
waywardmonkeys
force-pushed
the
initial-imaging_model
branch
from
aed02d7 to
593ac1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a first draft of the
imaging_modelcrate with clip-focused model types. The goal is to establish a small, explicit core model that we can evolve as we define the imaging model and move our renderers to using it.