Updated ZKHelixManager to use ZKCache #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d mode In distributed controller mode, when a CONTROLLER_PARTICIPANT becomes the leader for a managed cluster, it creates a new HelixManager with InstanceType.CONTROLLER. This CONTROLLER instance runs the intensive ReadClusterDataStage pipeline which benefits significantly from caching. This change enables ZkCacheBaseDataAccessor for CONTROLLER instances, caching the following ZK paths: - /<cluster>/LIVEINSTANCES - /<cluster>/INSTANCES - /<cluster>/IDEALSTATES - /<cluster>/CONFIGS CONTROLLER_PARTICIPANT instances (which participate in the grand cluster for leader election only) continue to use the non-cached ZkBaseDataAccessor since they don't run the ReadClusterDataStage pipeline.
ngngwr
changed the title
ngngwr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Rebalance Pipeline Optimisation Efforts
Description
ReadClusterDataStage waste lot of time waiting for the actual ZK call
Tests
Unit and Integration Tests Added.