Open
Conversation
siggy
reviewed
Jan 5, 2018
Member
siggy
left a comment
siggy
left a comment
There was a problem hiding this comment.
@mengskysama Thanks for doing this! We'd like to merge part of this PR. The CRD -> TPR change is happening as part of #203, would you backing that part of your PR out, and then we can merge the rest?
| --- | ||
| kind: ThirdPartyResource | ||
| apiVersion: extensions/v1beta1 | ||
| kind: CustomResourceDefinition |
Member
There was a problem hiding this comment.
we're updating from TPR -> CRD in a larger doc update (#203). would you mind backing this particular change out of your PR?
| kubectl apply -f k8s/certificates.yml | ||
| kubectl apply -f k8s/namerd.yml | ||
| kubectl apply -f k8s/linkerd-namerd-cni.yml | ||
| kubectl apply -f k8s/linkerd-namerd-cni-tls.yml |
|
|
||
| #### Daemonsets | ||
|
|
||
| If cluster enable RBAC please setting up the permission: |
Member
There was a problem hiding this comment.
This same information is capture in the RBAC section further down this file. What do you think about moving that section up to here, and combining it with what you have documented here?
|
|
||
| ```bash | ||
| kubectl apply -f k8s/certificates.yml | ||
| kubectl apply -f k8s/namerd-legacy.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.