refactor(app/inbound): router metrics middleware are T-agnostic
#4181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4119 introduced a
Permitted<T>structure, to provide a more formal notion of a(HttpRoutePermit, T)tuple.during review of #4180, we had a discussion about how the inbound proxy's http router had metrics layers which were tightly coupled to the notion of a
Permitted<T>:this branch performs a series of changes to explore what appears to be a promising alternative to the existing model of
Permitted<T>. importantly, this has the effect of leaving the inbound metrics layers' extractors agnostic to their target: they now provide implementations likesvc::ExtractParam<BodyDataMetrics, T>rather thansvc::ExtractParam<BodyDataMetrics, Permitted<T>>.