Skip to content

Comments

kbuild: keep symbols for symbol_get() even with CONFIG_TRIM_UNUSED_KSYMS#41

Closed
modules-kpd-app[bot] wants to merge 0 commit intomodules-next_basefrom
series/917838=>modules-next
Closed

kbuild: keep symbols for symbol_get() even with CONFIG_TRIM_UNUSED_KSYMS#41
modules-kpd-app[bot] wants to merge 0 commit intomodules-next_basefrom
series/917838=>modules-next

Conversation

@modules-kpd-app
Copy link

Pull request for series with
subject: kbuild: keep symbols for symbol_get() even with CONFIG_TRIM_UNUSED_KSYMS
version: 2
url: https://patchwork.kernel.org/project/linux-modules/list/?series=917844

@modules-kpd-app
Copy link
Author

Upstream branch: f3fda0d
series: https://patchwork.kernel.org/project/linux-modules/list/?series=917844
version: 2

@modules-kpd-app
Copy link
Author

Upstream branch: f3fda0d
series: https://patchwork.kernel.org/project/linux-modules/list/?series=917844
version: 2

@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from e9b2d87 to 77b0795 Compare December 16, 2024 17:00
@modules-kpd-app
Copy link
Author

Upstream branch: 8a231a1
series: https://patchwork.kernel.org/project/linux-modules/list/?series=917844
version: 2

@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from 77b0795 to 0a0c36d Compare January 2, 2025 14:06
@modules-kpd-app
Copy link
Author

Upstream branch: b7e6013
series: https://patchwork.kernel.org/project/linux-modules/list/?series=917844
version: 2

@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from 0a0c36d to e63d911 Compare January 6, 2025 13:58
@modules-kpd-app
Copy link
Author

Upstream branch: 0217859
series: https://patchwork.kernel.org/project/linux-modules/list/?series=917844
version: 2

@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from e63d911 to f744b24 Compare January 15, 2025 19:56
@modules-kpd-app
Copy link
Author

Upstream branch: f3b9354
series: https://patchwork.kernel.org/project/linux-modules/list/?series=917844
version: 2

@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from f744b24 to 9f22238 Compare January 28, 2025 08:22
@modules-kpd-app
Copy link
Author

Upstream branch: 48ecfdd
series: https://patchwork.kernel.org/project/linux-modules/list/?series=917844
version: 2

@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from 9f22238 to c70a063 Compare January 30, 2025 13:45
@modules-kpd-app
Copy link
Author

Upstream branch: 48ecfdd
series: https://patchwork.kernel.org/project/linux-modules/list/?series=929746
version: 3

@modules-kpd-app modules-kpd-app bot added V3 and removed V2 labels Feb 1, 2025
@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from c70a063 to 07a33c0 Compare February 1, 2025 18:55
@modules-kpd-app
Copy link
Author

Upstream branch: 053842e
series: https://patchwork.kernel.org/project/linux-modules/list/?series=929746
version: 3

@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from 07a33c0 to 970b781 Compare February 4, 2025 12:19
@modules-kpd-app
Copy link
Author

Upstream branch: afa9286
series: https://patchwork.kernel.org/project/linux-modules/list/?series=929746
version: 3

@modules-kpd-app modules-kpd-app bot closed this Feb 17, 2025
@modules-kpd-app modules-kpd-app bot force-pushed the series/917838=>modules-next branch from 970b781 to b5b7508 Compare February 17, 2025 10:03
@modules-kpd-app modules-kpd-app bot deleted the series/917838=>modules-next branch March 4, 2025 15:30
modules-kpd-app bot pushed a commit that referenced this pull request Mar 18, 2025
Commit b15c872 ("hwpoison, memory_hotplug: allow hwpoisoned pages to
be offlined) add page poison checks in do_migrate_range in order to make
offline hwpoisoned page possible by introducing isolate_lru_page and
try_to_unmap for hwpoisoned page.  However folio lock must be held before
calling try_to_unmap.  Add it to fix this problem.

Warning will be produced if folio is not locked during unmap:

  ------------[ cut here ]------------
  kernel BUG at ./include/linux/swapops.h:400!
  Internal error: Oops - BUG: 00000000f2000800 [#1] PREEMPT SMP
  Modules linked in:
  CPU: 4 UID: 0 PID: 411 Comm: bash Tainted: G        W          6.13.0-rc1-00016-g3c434c7ee82a-dirty #41
  Tainted: [W]=WARN
  Hardware name: QEMU QEMU Virtual Machine, BIOS 0.0.0 02/06/2015
  pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
  pc : try_to_unmap_one+0xb08/0xd3c
  lr : try_to_unmap_one+0x3dc/0xd3c
  Call trace:
   try_to_unmap_one+0xb08/0xd3c (P)
   try_to_unmap_one+0x3dc/0xd3c (L)
   rmap_walk_anon+0xdc/0x1f8
   rmap_walk+0x3c/0x58
   try_to_unmap+0x88/0x90
   unmap_poisoned_folio+0x30/0xa8
   do_migrate_range+0x4a0/0x568
   offline_pages+0x5a4/0x670
   memory_block_action+0x17c/0x374
   memory_subsys_offline+0x3c/0x78
   device_offline+0xa4/0xd0
   state_store+0x8c/0xf0
   dev_attr_store+0x18/0x2c
   sysfs_kf_write+0x44/0x54
   kernfs_fop_write_iter+0x118/0x1a8
   vfs_write+0x3a8/0x4bc
   ksys_write+0x6c/0xf8
   __arm64_sys_write+0x1c/0x28
   invoke_syscall+0x44/0x100
   el0_svc_common.constprop.0+0x40/0xe0
   do_el0_svc+0x1c/0x28
   el0_svc+0x30/0xd0
   el0t_64_sync_handler+0xc8/0xcc
   el0t_64_sync+0x198/0x19c
  Code: f9407be0 b5fff320 d4210000 17ffff97 (d4210000)
  ---[ end trace 0000000000000000 ]---

Link: https://lkml.kernel.org/r/20250217014329.3610326-4-mawupeng1@huawei.com
Fixes: b15c872 ("hwpoison, memory_hotplug: allow hwpoisoned pages to be offlined")
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
Acked-by: David Hildenbrand <david@redhat.com>
Acked-by: Miaohe Lin <linmiaohe@huawei.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
modules-kpd-app bot pushed a commit that referenced this pull request May 5, 2025
Commit ddd0a42 only increments scomp_scratch_users when it was 0,
causing a panic when using ipcomp:

    Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI
    KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
    CPU: 1 UID: 0 PID: 619 Comm: ping Tainted: G                 N  6.15.0-rc3-net-00032-ga79be02bba5c #41 PREEMPT(full)
    Tainted: [N]=TEST
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Arch Linux 1.16.3-1-1 04/01/2014
    RIP: 0010:inflate_fast+0x5a2/0x1b90
    [...]
    Call Trace:
     <IRQ>
     zlib_inflate+0x2d60/0x6620
     deflate_sdecompress+0x166/0x350
     scomp_acomp_comp_decomp+0x45f/0xa10
     scomp_acomp_decompress+0x21/0x120
     acomp_do_req_chain+0x3e5/0x4e0
     ipcomp_input+0x212/0x550
     xfrm_input+0x2de2/0x72f0
    [...]
    Kernel panic - not syncing: Fatal exception in interrupt
    Kernel Offset: disabled
    ---[ end Kernel panic - not syncing: Fatal exception in interrupt ]---

Instead, let's keep the old increment, and decrement back to 0 if the
scratch allocation fails.

Fixes: ddd0a42 ("crypto: scompress - Fix scratch allocation failure handling")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants