module: Taint the kernel when write-protecting ro_after_init fails#60
Closed
modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
Closed
module: Taint the kernel when write-protecting ro_after_init fails#60modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
Conversation
Author
|
Upstream branch: afa9286 |
Author
|
Upstream branch: afa9286 |
modules-kpd-app
bot
force-pushed
the
series/940956=>modules-next
branch
from
87c7db5 to
5519fcb
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
b5b7508 to
96f6e22
Compare
Author
|
Upstream branch: 085c5e3 |
modules-kpd-app
bot
force-pushed
the
series/940956=>modules-next
branch
from
5519fcb to
0d5ca8f
Compare
dagomez137
force-pushed
the
modules-next_base
branch
from
96f6e22 to
7c2b408
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
7c2b408 to
2996654
Compare
Author
|
Upstream branch: 897c0b4 |
modules-kpd-app
bot
force-pushed
the
series/940956=>modules-next
branch
from
0d5ca8f to
763fd3e
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
2996654 to
d4037eb
Compare
Author
|
Upstream branch: b464e57 |
modules-kpd-app
bot
force-pushed
the
series/940956=>modules-next
branch
from
763fd3e to
cba9279
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
d4037eb to
39f16b8
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
39f16b8 to
d6fb02c
Compare
Author
|
Upstream branch: a0b018a |
modules-kpd-app
bot
force-pushed
the
series/940956=>modules-next
branch
from
cba9279 to
6b3b34d
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
d6fb02c to
b788ac1
Compare
In the unlikely case that setting ro_after_init data to read-only fails, it is too late to cancel loading of the module. The loader then issues only a warning about the situation. Given that this reduces the kernel's protection, it was suggested to make the failure more visible by tainting the kernel. Allow TAINT_BAD_PAGE to be set per-module and use it in this case. The flag is set in similar situations and has the following description in Documentation/admin-guide/tainted-kernels.rst: "bad page referenced or some unexpected page flags". Adjust the warning that reports the failure to avoid references to internal functions and to add information about the kernel being tainted, both to match the style of other messages in the file. Additionally, merge the message on a single line because checkpatch.pl recommends that for the ability to grep for the string. Suggested-by: Kees Cook <kees@kernel.org> Signed-off-by: Petr Pavlu <petr.pavlu@suse.com> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Author
|
Upstream branch: a0b018a |
modules-kpd-app
bot
force-pushed
the
series/940956=>modules-next
branch
from
6b3b34d to
784f0b9
Compare
dagomez137
force-pushed
the
modules-next_base
branch
from
b788ac1 to
e04c78d
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
cbdca0b to
6a1a12c
Compare
dagomez137
force-pushed
the
modules-next_base
branch
from
6a1a12c to
7c2b408
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
2 times, most recently
from
6381fa5 to
aaa7ece
Compare
dagomez137
force-pushed
the
modules-next_base
branch
2 times, most recently
from
b4d1c4e to
61dc34e
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
2 times, most recently
from
1df8185 to
9aab33d
Compare
dagomez137
force-pushed
the
modules-next_base
branch
from
9aab33d to
99d099e
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
99d099e to
3aed49d
Compare
dagomez137
force-pushed
the
modules-next_base
branch
from
3aed49d to
856647c
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
856647c to
e1b99f5
Compare
dagomez137
force-pushed
the
modules-next_base
branch
from
e1b99f5 to
856647c
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
3 times, most recently
from
0299e02 to
cdc6b9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: module: Taint the kernel when write-protecting ro_after_init fails
version: 1
url: https://patchwork.kernel.org/project/linux-modules/list/?series=940956