kbuild: Require pahole >v1.29 with GENDWARFKSYMS and BTF on X86#65
Closed
modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
Closed
kbuild: Require pahole >v1.29 with GENDWARFKSYMS and BTF on X86#65modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
Conversation
With CONFIG_GENDWARFKSYMS, __gendwarfksyms_ptr variables are added
to the kernel in EXPORT_SYMBOL() to ensure DWARF type information
is available for exported symbols in the TUs where they're actually
exported. These symbols are dropped when linking vmlinux, but
dangling references to them remain in DWARF.
With CONFIG_DEBUG_INFO_BTF enabled on X86, pahole versions
before commit 9810758003ce ("btf_encoder: Verify 0 address
DWARF variables are in ELF section") place these symbols in the
.data..percpu section, which results in an "Invalid offset" error in
btf_datasec_check_meta() during boot, as all the variables are at
zero offset and have non-zero size. If CONFIG_DEBUG_INFO_BTF_MODULES
is enabled, this also results in a failure to load modules with:
failed to validate module [$module] BTF: -22
The pahole commit that adds 0 address DWARF variable verification
was merged after v1.29 was released, so later versions of pahole
shouldn't have this issue. Require pahole >v1.29 when GENDWARFKSYMS
is enabled with DEBUG_INFO_BTF on X86.
Reported-by: Paolo Pisati <paolo.pisati@canonical.com>
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Author
|
Upstream branch: 085c5e3 |
dagomez137
force-pushed
the
modules-next_base
branch
from
96f6e22 to
7c2b408
Compare
modules-kpd-app
bot
force-pushed
the
modules-next_base
branch
from
7c2b408 to
2996654
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/linux-modules/list/?series=946078 irrelevant now. Closing PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: kbuild: Require pahole >v1.29 with GENDWARFKSYMS and BTF on X86
version: 1
url: https://patchwork.kernel.org/project/linux-modules/list/?series=946078