Skip to content

[PW_SID:1054702] Add Tenstorrent Atlantis Clock/Reset Controller#1477

Closed
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1054702
Closed

[PW_SID:1054702] Add Tenstorrent Atlantis Clock/Reset Controller#1477
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1054702

Conversation

@linux-riscv-bot
Copy link

PR for series 1054702 applied to workflow__riscv__fixes

Name: Add Tenstorrent Atlantis Clock/Reset Controller
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1054702
Version: 6

Anirudh Srinivasan added 3 commits February 16, 2026 22:26
Document bindings for Tenstorrent Atlantis PRCM that manages clocks
and resets. This block is instantiated multiple times in the SoC.
This commit documents the clocks from the RCPU PRCM block.

Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Adds Atlantis Reset Controller driver, which shares the same regmap as
prcm ( clock controller).

This version of the reset controller driver covers resets from the RCPU
prcm.

Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Add driver for clock controller in Tenstorrent Atlantis SoC. This version
of the driver coves clocks from RCPU syscon.

5 types of clocks generated by this controller: PLLs (PLLs
with bypass functionality and an additional Gate clk at output), Shared
Gates (Multiple Gate clks that share an enable bit), standard Muxes,
Dividers and Gates. All clocks are implemented using custom clk ops and
use the regmap interface associated with the syscon. All clocks are derived
from a 24 Mhz oscillator.

The reset controller is also setup as an auxiliary device of the clock
controller.

Signed-off-by: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 112.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1177.42 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1483.53 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 22.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 24.40 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.54 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 79.10 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
kdoc
Desc: Detects for kdoc errors
Duration: 0.95 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
module-param
Desc: Detect module_param changes
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v6,1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm-rcpu"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 110.57 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1206.13 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1599.69 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 23.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 24.51 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 2.49 seconds
Result: WARNING
Output:

CHECK: Please use a blank line after function/struct/union/enum declarations
#210: FILE: drivers/reset/reset-tenstorrent-atlantis.c:137:
+}
+static int atlantis_reset_probe(struct auxiliary_device *adev,

total: 0 errors, 0 warnings, 1 checks, 204 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit a30805e24af4 ("reset: tenstorrent: Add reset controller for Atlantis") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 1 checks, 204 lines checked
CHECK: Please use a blank line after function/struct/union/enum declarations


@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
kdoc
Desc: Detects for kdoc errors
Duration: 0.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
module-param
Desc: Detect module_param changes
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v6,2/3] reset: tenstorrent: Add reset controller for Atlantis"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 111.59 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1247.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1707.44 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 22.75 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 24.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.61 seconds
Result: WARNING
Output:

CHECK: spinlock_t definition without comment
#209: FILE: drivers/clk/tenstorrent/atlantis-prcm.c:106:
+	spinlock_t *refcount_lock;

CHECK: Macro argument '_parent' may be better as '(_parent)' to avoid precedence issues
#630: FILE: drivers/clk/tenstorrent/atlantis-prcm.c:527:
+#define ATLANTIS_DIVIDER_DEFINE(_clkid, _name, _parent, _reg_offset, _shift, \
+				_width, _divflags, _flags)                   \
+	static struct atlantis_clk_divider _name = {                         \
+		.config = ATLANTIS_DIVIDER_CONFIG(_shift, _width, _divflags, \
+						  _reg_offset),              \
+		.common = { .clkid = _clkid,                                 \
+			    .hw.init = CLK_HW_INIT_HW(                       \
+				    #_name, &_parent.common.hw,              \
+				    &atlantis_clk_divider_ops, _flags) }     \
+	}

CHECK: Macro argument '_parent' may be better as '(_parent)' to avoid precedence issues
#645: FILE: drivers/clk/tenstorrent/atlantis-prcm.c:542:
+#define ATLANTIS_GATE_DEFINE(_clkid, _name, _parent, _reg_offset, _enable, \
+			     _flags)                                       \
+	static struct atlantis_clk_gate _name = {                          \
+		.config = ATLANTIS_GATE_CONFIG(_enable, _reg_offset),      \
+		.common = { .clkid = _clkid,                               \
+			    .hw.init = CLK_HW_INIT_HW(                     \
+				    #_name, &_parent.common.hw,            \
+				    &atlantis_clk_gate_ops, _flags) }      \
+	}

CHECK: Macro argument '_parent' may be better as '(_parent)' to avoid precedence issues
#659: FILE: drivers/clk/tenstorrent/atlantis-prcm.c:556:
+#define ATLANTIS_GATE_SHARED_DEFINE(_clkid, _name, _parent, _reg_offset,     \
+				    _enable, _share_count, _flags)           \
+	static struct atlantis_clk_gate_shared _name = {                     \
+		.config = ATLANTIS_GATE_SHARED_CONFIG(_reg_offset, _enable,  \
+						      _share_count),         \
+		.common = { .clkid = _clkid,                                 \
+			    .hw.init = CLK_HW_INIT_HW(                       \
+				    #_name, &_parent.common.hw,              \
+				    &atlantis_clk_gate_shared_ops, _flags) } \
+	}

CHECK: Macro argument '_parent' may be better as '(_parent)' to avoid precedence issues
#669: FILE: drivers/clk/tenstorrent/atlantis-prcm.c:566:
+#define ATLANTIS_CLK_FIXED_FACTOR_DEFINE(_clkid, _name, _parent, _mult, _div, \
+					 _flags)                              \
+	static struct atlantis_clk_fixed_factor _name = {                     \
+		.config = { .mult = _mult, .div = _div },                     \
+		.common = { .clkid = _clkid,                                  \
+			    .hw.init = CLK_HW_INIT_HW(                        \
+				    #_name, &_parent.common.hw,               \
+				    &atlantis_clk_fixed_factor_ops, _flags) } \
+	}

CHECK: Lines should not end with a '('
#765: FILE: drivers/clk/tenstorrent/atlantis-prcm.c:662:
+				 .hw.init = CLK_HW_INIT_PARENTS_DATA(

total: 0 errors, 0 warnings, 6 checks, 939 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 1a738aec80eb ("clk: tenstorrent: Add Atlantis clock controller driver") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 6 checks, 939 lines checked
CHECK: Lines should not end with a '('
CHECK: Macro argument '_parent' may be better as '(_parent)' to avoid precedence issues
CHECK: spinlock_t definition without comment


@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 78.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
kdoc
Desc: Detects for kdoc errors
Duration: 1.05 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
module-param
Desc: Detect module_param changes
Duration: 0.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v6,3/3] clk: tenstorrent: Add Atlantis clock controller driver"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1054702 branch February 17, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant