Skip to content

Comments

[PW_SID:1054156] phy: spacemit: Add USB2 PHY support for K3 SoC#1478

Closed
linux-riscv-bot wants to merge 3 commits intoworkflowfrom
pw1054156
Closed

[PW_SID:1054156] phy: spacemit: Add USB2 PHY support for K3 SoC#1478
linux-riscv-bot wants to merge 3 commits intoworkflowfrom
pw1054156

Conversation

@linux-riscv-bot
Copy link

PR for series 1054156 applied to workflow

Name: phy: spacemit: Add USB2 PHY support for K3 SoC
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1054156
Version: 2

Yixun Lan added 3 commits February 17, 2026 20:45
Introduce a compatible string for the USB2 PHY in SpacemiT K3 SoC. The IP
of USB2 PHY mostly shares the same functionalities with K1 SoC, while has
some register layout changes.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Yixun Lan <dlan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
A disconnect status BIT of USB2 PHY need to be cleared, otherwise
it will fail to work properly during next connection when devices
connect to roothub directly.

Fixes: fe4bc1a ("phy: spacemit: support K1 USB2.0 PHY controller")
Signed-off-by: Yixun Lan <dlan@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Add USB2 PHY support for SpacemiT K3 SoC.

Register layout of handling USB disconnect operation has been changed,
So introducing a platform data to distinguish the different SoCs.

Signed-off-by: Yixun Lan <dlan@kernel.org>
Reviewed-by: Yao Zi <me@ziyao.cc>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 140.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 996.46 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1348.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 29.36 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 30.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.41 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.99 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[v2,1/3] dt-bindings: phy: spacemit: k3: add USB2 PHY support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot linux-riscv-bot deleted the pw1054156 branch February 17, 2026 21:34
@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 139.41 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1025.10 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1380.76 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 29.84 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.83 seconds
Result: WARNING
Output:

CHECK: Alignment should match open parenthesis
#40: FILE: drivers/phy/spacemit/phy-k1-usb2.c:153:
+	regmap_update_bits(sphy->regmap_base, PHY_K1_HS_HOST_DISC,
+					   PHY_K1_HS_HOST_DISC_CLR, PHY_K1_HS_HOST_DISC_CLR);

total: 0 errors, 0 warnings, 1 checks, 29 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 0dddf326f8ca ("phy: k1-usb: add disconnect function support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 1 checks, 29 lines checked
CHECK: Alignment should match open parenthesis


@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.95 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.28 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[v2,2/3] phy: k1-usb: add disconnect function support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 140.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1025.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1376.58 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 29.58 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.86 seconds
Result: WARNING
Output:

CHECK: Alignment should match open parenthesis
#51: FILE: drivers/phy/spacemit/phy-k1-usb2.c:166:
+	regmap_update_bits(sphy->regmap_base, PHY_K3_HS_HOST_DISC,
+					   PHY_K3_HS_HOST_DISC_CLR, PHY_K3_HS_HOST_DISC_CLR);

total: 0 errors, 0 warnings, 1 checks, 78 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit ad648583f4d4 ("phy: k1-usb: k3: add USB2 PHY support") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 0 warnings, 1 checks, 78 lines checked
CHECK: Alignment should match open parenthesis


@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 83.58 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.97 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[v2,3/3] phy: k1-usb: k3: add USB2 PHY support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant