ci: Add support for bootc end-to-end validation tests

[richm]

NOTE: This also requires upgrading to tox-lsr 3.10.0, and some
hacks to workaround a podman issue in ubuntu.

These tests run the role during a bootc container image build, deploy
the container into a QEMU VM, boot that, and validate the expected
configuration there. They run in two different tox environments, and
thus have to be run in two steps (preparation in buildah, validation in
QEMU). The preparation is expected to output a qcow2 image in
tests/tmp/TESTNAME/qcow2/disk.qcow2, i.e. the output structure of
https://github.com/osbuild/bootc-image-builder.

There are two possibilities:

• Have separate bootc end-to-end tests. These are tagged with
  tests::bootc-e2 and are skipped in the normal qemu-* scenarios.
  They run as part of the container-* ones.

• Modify an existing test: These need to build a qcow2 image exactly
  once (via calling bootc-buildah-qcow.sh) and skip setup/cleanup
  and role invocations in validation mode, i.e. when
  __bootc_validation is true.

In the container scenario, run the QEMU validation as a separate step in
the workflow.

See https://issues.redhat.com/browse/RHEL-88396

[sourcery-ai]

Reviewer's Guide

This PR adds support for bootc end-to-end validation by upgrading the tox-lsr dependency across CI workflows, injecting a podman 5.x compatibility hack for bootc container builds, and extending the QEMU integration pipeline with a dedicated validation step that runs tests inside a QEMU VM using generated qcow2 images.

Sequence Diagram for Bootc End-to-End Validation Test Flow

sequenceDiagram
    actor User/CI
    participant WF as GitHub Actions Workflow
    participant BuildahEnv as "Buildah Environment (Preparation)"
    participant QEMU_VM as "QEMU VM (Validation)"

    User/CI->>+WF: Trigger bootc E2E tests
    WF->>+BuildahEnv: Start Preparation Phase
    BuildahEnv->>BuildahEnv: Run bootc-buildah-qcow.sh / bootc-image-builder
    Note over BuildahEnv: Builds container, applies Podman hack, generates qcow2
    BuildahEnv-->>-WF: disk.qcow2 created
    WF->>+QEMU_VM: Start Validation Phase (with disk.qcow2)
    QEMU_VM->>QEMU_VM: Deploy qcow2 image to QEMU
    QEMU_VM->>QEMU_VM: Boot VM
    QEMU_VM->>QEMU_VM: Run validation tests (with __bootc_validation=true)
    QEMU_VM-->>-WF: Test results
    WF-->>-User/CI: Report status

Loading

File-Level Changes

Change	Details	Files
Upgrade tox-lsr to version 3.10.0 in CI pipelines	Bump tox-lsr install reference from 3.9.0 to 3.10.0 in multiple workflows	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Add podman 5.x compatibility hack for bootc image builds	Conditionally add Ubuntu 'plucky' apt sources and pin package priorities for podman Install updated podman, crun, conmon, and container storage dependencies under bootc scenarios	.github/workflows/qemu-kvm-integration-tests.yml
Extend QEMU integration workflow with bootc end-to-end validation step	Adjust skip-tags to exclude 'tests::bootc-e2e' in initial QEMU run Introduce a new job step that loops over generated qcow2 images to run validation in a QEMU VM Pass the __bootc_validation flag and capture separate PASS/FAIL logs for each test	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @richm - I've reviewed your changes - here's some feedback:

• The podman upgrade hack via sed and pinning Ubuntu codename is quite brittle—consider using an officially supported backport or updated base image instead.
• The skip-tags value uses tests::bootc-e2e but the description references tests::bootc-e2—please ensure the tag names are consistent.
• You install the same tox-lsr@3.10.0 line in multiple workflows—extract that into a shared variable or reusable action to DRY up the YAML.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Review instructions: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}