add Binary-Blobs and Maintainers-and-Testers pages #210
Conversation
use defaults but custom branch Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
taken from OP of linuxboot/heads#692 - split into two pages - add section on maintainers - remove out-of-date section on MRC blobs (not used anymore) Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
gaspar-ilom
force-pushed
the
problem-resolution
branch
from
532277c to
709b497
Compare
gaspar-ilom
force-pushed
the
problem-resolution
branch
3 times, most recently
from
f8d72e9 to
3d2787c
Compare
Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
gaspar-ilom
force-pushed
the
problem-resolution
branch
from
3d2787c to
2cd71d1
Compare
| Maintainers | ||
| === | ||
|
|
||
| - [@tlaurion](https://github.com/tlaurion) (was Insurgo, not selling hardware anymore, project is currently under-funded) |
There was a problem hiding this comment.
->
fixup for prod
@tlaurion: was Insurgo, now freelance. See https://osresearch.net/Consultation-Services/ ...
Capitals missing:
...Nitrokey
...Purism
osresearch needs justice
…in ME, no MRC), put back Boradwell+ req on MRC blob Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…link fixup to BOARDS_AND_TESTERS.md Signed-off-by: Thierry Laurion <insurgo@riseup.net>
|
Put to draft because of incertitude
|
gaspar-ilom
force-pushed
the
problem-resolution
branch
2 times, most recently
from
e89488d to
be6681a
Compare
taken from OP of linuxboot/heads#692 - split into two pages - add section on maintainers - remove out-of-date section on MRC blobs (not used anymore) - include BOARDS_AND_TESTERS.md from main repo - force inclusion in [local]_config.yml - allow triggering wiki deployment from heads repo Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
gaspar-ilom
force-pushed
the
problem-resolution
branch
from
7c9f624 to
6cedf2d
Compare
now included in main repo BOARDS_AND_TESTERS.md Signed-off-by: gaspar-ilom <gasparilom@riseup.net>
|
@tlaurion Sorry I thought this was still marked as a draft and changed some stuff (force-pushed quite a bit). Only saw your review now. Sorry about that. The ci workflow is now setup and works more or less as expected, although some references would have to be fixed when merging this. It works now as a proof of concept on how to include a file or folders even from the main heads repo. I have created a github action in the main repo (on my branch) to trigger redeployment of the wiki in case some of its dependencies changed. So a change in either repos will now trigger redeployment of the wiki making sure its is always up-to-date without additional manual action needed to be taken. Apart from that I remove the Maintainer-and-Testers.md again and included its content in the BOARDS_AND_TESTERS.md file. The wiki could also use the main repo as a submodule with sparse checkout of the relevant files only, which might make the dependencies clearer. Could still trigger the redeployment automatically. My goal here was not just using one file from heads but allowing to have board specific docs maintained in the main repo and use them from the wiki. Just some ideas I had. If you don't like it it should not be too hard to roll it back to the state when you reviewed (and include your comments). Still don't like it? |
…aurion_problem-resolution With conflicts resolved Signed-off-by: Thierry Laurion <insurgo@riseup.net>
|
@gaspar-ilom I love it. I merged my previous changes to this pr state I kept in a local branch at https://github.com/tlaurion/heads-wiki/tree/tlaurion_problem-resolution rendered at https://tlaurion.github.io/heads-wiki/ Please take a look and poke me back. My branch addresses all this PR review comments AFAIK. |
gaspar-ilom
left a comment
gaspar-ilom
left a comment
There was a problem hiding this comment.
Thanks @tlaurion
I have resolved your former review comments, but created some of my own
Also triggering automatic re-deployment upon changing the BOARDS_AND_TESTER.md would require a github action in the main repo:
| ===== | ||
|
|
||
| - [FSP is present in all Broadwell+ platforms](https://doc.coreboot.org/soc/intel/fsp/index.html) | ||
| - [MRC blob present in all Broadwell+ plaforms](https://doc.coreboot.org/soc/intel/broadwell/blobs.html) |
There was a problem hiding this comment.
MRC is included in the FSP after Broadwell if I am not mistaken?! So why mention it explicitly here? Also: does Heads even have any Broadwell boards? I have no good overview...
There was a problem hiding this comment.
MRC is included in the FSP after Broadwell if I am not mistaken?!
Broadwell platforms depend on MRC blob:
https://pagure.io/libreboot/c/4134a883d0d8dd4020f2ddca7416e0b9f82b8843?branch=9020tpm
This is why I added
MRC blob present in all Broadwell+ plaforms
Broadwell is generation on which FSP was introduced, as referred by
FSP is present in all Broadwell+ platforms
We can see arrival of FSP-M, but this is FSP first gen.
Maybe we should say:
FSP is present in all >=Broadwell platforms
MRC blob present in >=Broadwell plaforms
@gaspar-ilom thoughts?
There was a problem hiding this comment.
Also: does Heads even have any Broadwell boards? I have no good overview...
Not for now, no. But those timeline hints are general guidelines for blobs presence, just like previously it was said that MRC blob was needed for Haswell+ before Heads included some, first with MRC blobs and then without. Same could happen with Broadwell, which is next platform for MRC blob presence.
Post Broadwell; FSP (f/m/p) are present and can be seen referred in coreboot configs and coreboot/fork trees.
| - name: Fetch sources from main repo | ||
| working-directory: ./Development | ||
| run: | | ||
| curl -H 'Accept: application/vnd.github+raw' -O -L https://raw.githubusercontent.com/gaspar-ilom/heads/heads-wiki-actions/BOARDS_AND_TESTERS.md |
There was a problem hiding this comment.
Fix the source before merging
| on: | ||
| # Runs on pushes targeting the default branch or triggered from main repo in case md files are pushed there | ||
| push: | ||
| branches: ["master", "problem-resolution"] |
There was a problem hiding this comment.
We should only deploy to prod from master. For development we might want to run from all branches though?! This could be done with manual runs, but maybe it is not that convenient.
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.client_payload.ref }} |
There was a problem hiding this comment.
Might not need this. Just for testing while it is not yet on master.
There was a problem hiding this comment.
I would like to remove this file as per one of my previous commits and use this instead: https://github.com/gaspar-ilom/heads/blob/heads-wiki-actions/BOARDS_AND_TESTERS.md rendered https://gaspar-ilom.github.io/heads-wiki/Boards-and-Testers/
Did you bring it back on purpose cb31412 ?
I added the main content from Maintainers-and-Testers.md to the main repo but your recent changes are still missing. What do you say?
There was a problem hiding this comment.
I guess next step is to bring up pr on master @gaspar-ilom with linuxboot/heads@master...gaspar-ilom:heads:heads-wiki-actions (but modified to trigger on linuxboot/heads for linuxboot/heads-wiki?)
2 participants
Taken from the OP of linuxboot/heads#692
Not really sure if this a good solution. I split it because blobs and testing related stuff hardly belong on the same page.
Rendered version: https://gaspar-ilom.github.io/heads-wiki