-
Notifications
You must be signed in to change notification settings - Fork 24
fix: add security hardening flags to build process #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning
详情 {
"export": {
"debian/rules": {
"b": [
"export DEB_BUILD_MAINT_OPTIONS = hardening=+all",
"export DEB_CFLAGS_MAINT_APPEND = -fstack-protector-all -Wall",
"export DEB_CXXFLAGS_MAINT_APPEND = -fstack-protector-all -Wall",
"export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -Wl,-E"
]
}
}
} |
Reviewer's GuideThis PR enhances the Debian package build process by injecting comprehensive hardening options and security flags into the compiler and linker invocations via updates to debian/rules. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
1. Added DEB_BUILD_MAINT_OPTIONS with hardening=+all 2. Appended security flags to C/CXX compilers (-fstack-protector-all, -Wall) 3. Added linker security flags (RELRO, NOW, noexecstack, -E) 4. These changes improve binary security by enabling various protections against common vulnerabilities fix: 在构建过程中添加安全加固标志 1. 添加了带有 hardening=+all 的 DEB_BUILD_MAINT_OPTIONS 2. 向 C/CXX 编译器追加安全标志 (-fstack-protector-all, -Wall) 3. 添加了链接器安全标志 (RELRO, NOW, noexecstack, -E) 4. 这些更改通过启用针对常见漏洞的各种保护来提高二进制安全性
|
Warning
详情 {
"export": {
"debian/rules": {
"b": [
"export DEB_BUILD_MAINT_OPTIONS = hardening=+all",
"export DEB_CFLAGS_MAINT_APPEND = -Wall",
"export DEB_CXXFLAGS_MAINT_APPEND = -Wall",
"export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -Wl,-E"
]
}
}
} |
deepin pr auto review关键摘要:
是否建议立即修改:
其他建议:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
-Wall)
against common vulnerabilities
fix: 在构建过程中添加安全加固标志
Summary by Sourcery
Enable security hardening in the Debian build by configuring maintainer options and adding compiler and linker flags to strengthen binary protections.
Enhancements:
Build: