refactor: remove trigger handler script and simplify reload logic #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning
|
Reviewer's GuideThis refactor removes the redundant trigger handler script and CMake option, replacing the multi-step reload process with a direct D-Bus reload call and updating Debian packaging accordingly. Sequence diagram for simplified post-install configuration reloadsequenceDiagram
participant Postinst as Debian postinst script
participant DConfigDaemon as dde-dconfig-daemon (D-Bus service)
Postinst->>DConfigDaemon: Call D-Bus reload interface
DConfigDaemon-->>Postinst: Reload complete
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
- Add error handling and logging around the direct D-Bus reload call in the postinst script to gracefully handle cases where the daemon isn’t ready or the message bus is unavailable.
- Ensure that upgrading from earlier versions properly cleans up any leftover trigger handler scripts under /lib/dde-dconfig-daemon to avoid stale files after the refactor.
- Validate the new reload logic across all install scenarios (initial install, upgrade, containerized environments) to confirm the daemon is active before invoking D-Bus reload.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add error handling and logging around the direct D-Bus reload call in the postinst script to gracefully handle cases where the daemon isn’t ready or the message bus is unavailable.
- Ensure that upgrading from earlier versions properly cleans up any leftover trigger handler scripts under /lib/dde-dconfig-daemon to avoid stale files after the refactor.
- Validate the new reload logic across all install scenarios (initial install, upgrade, containerized environments) to confirm the daemon is active before invoking D-Bus reload.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
1. Removed INSTALL_DEBIAN_TRIGGER CMake option and associated trigger handler script 2. Simplified post-install trigger handling by directly calling D-Bus reload interface 3. Eliminated intermediate script layer for more direct and reliable configuration reloads 4. Updated Debian packaging rules to reflect these changes The changes were made to: - Reduce maintenance overhead by removing an unnecessary script layer - Improve reliability by directly interacting with D-Bus service - Simplify the configuration reload process - Remove unused build configuration option refactor: 移除触发器处理脚本并简化重载逻辑 1. 移除了INSTALL_DEBIAN_TRIGGER CMake选项及相关触发器处理脚本 2. 简化了安装后触发器处理，直接调用D-Bus重载接口 3. 消除了中间脚本层，使配置重载更直接可靠 4. 更新了Debian打包规则以反映这些变更 这些变更是为了： - 通过移除不必要的脚本层减少维护开销 - 通过直接与D-Bus服务交互提高可靠性 - 简化配置重载流程 - 移除未使用的构建配置选项
|
Warning
|
deepin pr auto review代码审查意见：
综上所述，建议在删除 |
mhduiy
approved these changes
Jul 11, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handler script
reload interface
configuration reloads
The changes were made to:
refactor: 移除触发器处理脚本并简化重载逻辑
这些变更是为了：
Summary by Sourcery
Remove the INSTALL_DEBIAN_TRIGGER CMake option and trigger handler script, simplify the configuration reload process by invoking the D-Bus interface directly, and update Debian packaging rules accordingly
Enhancements:
Build: