-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add version option to command line parser #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Added version option to QCommandLineParser in main.cpp to display version information 2. Removed DVERSION from debian/rules configuration as it's no longer needed 3. Maintained DTK_VERSION setting in build configuration The changes improve command line interface by adding standard --version flag support while simplifying the build configuration by removing redundant version setting. feat: 为命令行解析器添加版本选项 1. 在 main.cpp 中为 QCommandLineParser 添加版本选项以显示版本信息 2. 从 debian/rules 配置中移除不再需要的 DVERSION 参数 3. 保留构建配置中的 DTK_VERSION 设置 这些改动通过添加标准的 --version 标志支持改进了命令行界面,同时通过移除 冗余的版本设置简化了构建配置。
|
Warning
|
Reviewer's GuideAdds built-in --version support to the command-line interface by invoking QCommandLineParser's addVersionOption and streamlines packaging by removing the custom DVERSION setting while preserving the existing DTK_VERSION definition. Class diagram for QCommandLineParser usage updateclassDiagram
class main
class QCommandLineParser {
+addHelpOption()
+addVersionOption()
+addOption(option)
}
main --> QCommandLineParser : uses
QCommandLineParser : +addVersionOption()
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
- Make sure to call QCoreApplication::setApplicationVersion() before parsing so --version outputs the correct version string.
- With DVERSION removed from debian/rules, double-check that your packaging scripts still pick up the right version (e.g. via DTK_VERSION or debian/changelog).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Make sure to call QCoreApplication::setApplicationVersion() before parsing so --version outputs the correct version string.
- With DVERSION removed from debian/rules, double-check that your packaging scripts still pick up the right version (e.g. via DTK_VERSION or debian/changelog).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
version information
needed
The changes improve command line interface by adding standard --version
flag support while simplifying the build configuration by removing
redundant version setting.
feat: 为命令行解析器添加版本选项
这些改动通过添加标准的 --version 标志支持改进了命令行界面,同时通过移除
冗余的版本设置简化了构建配置。
Summary by Sourcery
Add a standard --version flag to the CLI and simplify Debian packaging by removing the redundant DVERSION setting.
New Features:
Build: