Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Jul 24, 2025

  1. Added version option to QCommandLineParser in main.cpp to display
    version information
  2. Removed DVERSION from debian/rules configuration as it's no longer
    needed
  3. Maintained DTK_VERSION setting in build configuration

The changes improve command line interface by adding standard --version
flag support while simplifying the build configuration by removing
redundant version setting.

feat: 为命令行解析器添加版本选项

  1. 在 main.cpp 中为 QCommandLineParser 添加版本选项以显示版本信息
  2. 从 debian/rules 配置中移除不再需要的 DVERSION 参数
  3. 保留构建配置中的 DTK_VERSION 设置

这些改动通过添加标准的 --version 标志支持改进了命令行界面,同时通过移除
冗余的版本设置简化了构建配置。

Summary by Sourcery

Add a standard --version flag to the CLI and simplify Debian packaging by removing the redundant DVERSION setting.

New Features:

  • Add --version option to the command-line parser to display application version.

Build:

  • Remove DVERSION from Debian packaging rules.
  • Retain DTK_VERSION setting in build configuration.

1. Added version option to QCommandLineParser in main.cpp to display
version information
2. Removed DVERSION from debian/rules configuration as it's no longer
needed
3. Maintained DTK_VERSION setting in build configuration

The changes improve command line interface by adding standard --version
flag support while simplifying the build configuration by removing
redundant version setting.

feat: 为命令行解析器添加版本选项

1. 在 main.cpp 中为 QCommandLineParser 添加版本选项以显示版本信息
2. 从 debian/rules 配置中移除不再需要的 DVERSION 参数
3. 保留构建配置中的 DTK_VERSION 设置

这些改动通过添加标准的 --version 标志支持改进了命令行界面,同时通过移除
冗余的版本设置简化了构建配置。
@18202781743 18202781743 requested review from BLumia and mhduiy July 24, 2025 12:11
@github-actions
Copy link

  • 检测到debian目录文件有变更: debian/rules

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

Adds built-in --version support to the command-line interface by invoking QCommandLineParser's addVersionOption and streamlines packaging by removing the custom DVERSION setting while preserving the existing DTK_VERSION definition.

Class diagram for QCommandLineParser usage update

classDiagram
    class main
    class QCommandLineParser {
        +addHelpOption()
        +addVersionOption()
        +addOption(option)
    }
    main --> QCommandLineParser : uses
    QCommandLineParser : +addVersionOption()
Loading

File-Level Changes

Change Details Files
Introduce standard --version flag support
  • Invoke parser.addVersionOption() on the QCommandLineParser instance
  • Leverage existing application metadata for version output
dconfig-center/dde-dconfig/main.cpp
Clean up redundant DVERSION packaging configuration
  • Remove custom DVERSION variable from debian/rules
  • Keep DTK_VERSION declaration intact for build continuity
debian/rules

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes - here's some feedback:

  • Make sure to call QCoreApplication::setApplicationVersion() before parsing so --version outputs the correct version string.
  • With DVERSION removed from debian/rules, double-check that your packaging scripts still pick up the right version (e.g. via DTK_VERSION or debian/changelog).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Make sure to call QCoreApplication::setApplicationVersion() before parsing so --version outputs the correct version string.
- With DVERSION removed from debian/rules, double-check that your packaging scripts still pick up the right version (e.g. via DTK_VERSION or debian/changelog).

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • main.cpp文件中添加了版本选项,但未检查是否需要更新相关的版本号。
  • debian/rules文件中移除了-DDVERSION=$(DEB_VERSION_UPSTREAM),可能影响构建过程。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 86a6d66 into linuxdeepin:master Jul 24, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants