-
Notifications
You must be signed in to change notification settings - Fork 24
fix: remove exit on postinst reload failure #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed the exit 1 command when configuration reload fails in postinst script to comply with Debian post-installation script standards. Post-installation scripts should not exit abnormally as it can break package management operations. The error logging and message output are preserved to ensure proper error reporting without interrupting the package installation process. fix: 移除 postinst 重载失败时的退出操作 移除 postinst 脚本中配置重载失败时的 exit 1 命令,以符合 Debian 安装后脚 本规范。安装后脚本不应异常退出,否则可能破坏包管理操作。保留错误日志和消 息输出功能,确保在不中断包安装过程的情况下进行正确的错误报告。
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe post-installation script no longer aborts the package installation on configuration reload failures; instead, it logs errors and outputs messages while allowing the installation process to continue. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Warning
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, liujianqiang-niu, mhduiy, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning
|
Removed the exit 1 command when configuration reload fails in postinst
script to comply with Debian post-installation script standards.
Post-installation scripts should not exit abnormally as it can break
package management operations. The error logging and message output
are preserved to ensure proper error reporting without interrupting the
package installation process.
fix: 移除 postinst 重载失败时的退出操作
移除 postinst 脚本中配置重载失败时的 exit 1 命令,以符合 Debian 安装后脚
本规范。安装后脚本不应异常退出,否则可能破坏包管理操作。保留错误日志和消
息输出功能,确保在不中断包安装过程的情况下进行正确的错误报告。
Summary by Sourcery
Bug Fixes: