Skip to content

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Sep 1, 2025

Changed the section resize mode from ResizeToContents to setting
a minimum section size of 400 pixels for the export view header in
OEMDialog. This prevents the header sections from becoming too narrow
when resizing, ensuring better readability and usability of the
interface.

fix: 设置导出视图表头的最小分区大小

将OEMDialog中导出视图表头的分区调整模式从ResizeToContents改为设置最小分
区大小为400像素。这可以防止调整大小时表头分区变得过窄,确保更好的界面可
读性和可用性。

@18202781743 18202781743 requested review from BLumia and mhduiy September 1, 2025 05:15
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

  • 检测到敏感词export变动
详情
    {
    "export": {
        "dconfig-center/dde-dconfig-editor/oemdialog.cpp": {
            "a": [
                "    m_exportView->header()->setSectionResizeMode(QHeaderView::ResizeToContents);"
            ],
            "b": [
                "    m_exportView->header()->setMinimumSectionSize(400);"
            ]
        }
    }
}

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 1, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjust signal handling in dde-dconfig-daemon to catch only termination signals and enforce a 400px minimum section width for the OEM export view header.

Sequence diagram for updated signal handling in dde-dconfig-daemon

sequenceDiagram
    participant OS as Operating System
    participant Daemon as dde-dconfig-daemon
    OS->>Daemon: Send SIGTERM or SIGINT
    Daemon->>Daemon: Handle termination signal (reset handler)
    Daemon->>Daemon: Perform cleanup and exit
Loading

Class diagram for OEMDialog export view header update

classDiagram
    class OEMDialog {
        - QTreeView* m_exportView
        - DSuggestButton* m_exportBtn
        + OEMDialog(QWidget *parent)
    }
    class QTreeView {
    }
    class QHeaderView {
        + setMinimumSectionSize(int)
    }
    OEMDialog --> QTreeView : contains
    QTreeView --> QHeaderView : header()
Loading

File-Level Changes

Change Details Files
Refine signal handling to catch termination signals correctly
  • Removed handlers for SIGSEGV, SIGILL, SIGABRT, SIGFPE
  • Added handlers for SIGTERM, SIGINT
dconfig-center/dde-dconfig-daemon/main.cpp
Set a minimum section size for the OEM export view header
  • Replaced ResizeToContents resize mode
  • Configured header to use setMinimumSectionSize(400)
dconfig-center/dde-dconfig-editor/oemdialog.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Changed the section resize mode from ResizeToContents to setting
a minimum section size of 400 pixels for the export view header in
OEMDialog. This prevents the header sections from becoming too narrow
when resizing, ensuring better readability and usability of the
interface.

fix: 设置导出视图表头的最小分区大小

将OEMDialog中导出视图表头的分区调整模式从ResizeToContents改为设置最小分
区大小为400像素。这可以防止调整大小时表头分区变得过窄,确保更好的界面可
读性和可用性。
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider making the minimum section size a configurable constant or compute it dynamically to better accommodate varying UI layouts instead of hardcoding 400.
  • When installing handlers for SIGTERM and SIGINT, consider preserving or chaining existing handlers and logging shutdown context to ensure a truly graceful termination.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the minimum section size a configurable constant or compute it dynamically to better accommodate varying UI layouts instead of hardcoding 400.
- When installing handlers for SIGTERM and SIGINT, consider preserving or chaining existing handlers and logging shutdown context to ensure a truly graceful termination.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

  • 检测到敏感词export变动
详情
    {
    "export": {
        "dconfig-center/dde-dconfig-editor/oemdialog.cpp": {
            "a": [
                "    m_exportView->header()->setSectionResizeMode(QHeaderView::ResizeToContents);"
            ],
            "b": [
                "    m_exportView->header()->setMinimumSectionSize(400);"
            ]
        }
    }
}

@18202781743 18202781743 changed the title master fix: set minimum section size for export view header Sep 1, 2025
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 87388f5 into linuxdeepin:master Sep 2, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants