-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Update translations for Lao locale #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TAG Bot TAG: 6.5.25 |
Reviewer's GuideThis PR introduces Lao locale support by adding two new Qt translation files for the main application and desktop entry, and records the localization update in the Debian changelog. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JWWTSL - I've reviewed your changes - here's some feedback:
- Update the TS header to set language="lo" and sourcelanguage="en" to correctly configure the Lao translation file.
- Double-check that all placeholder tokens (e.g. %1) and newline markers match the source strings exactly to avoid runtime formatting issues.
- Review the attributes in desktop_lo.ts to ensure the desktop entry keys (Name, Comment, GenericName) are correctly referenced.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Update the TS header to set language="lo" and sourcelanguage="en" to correctly configure the Lao translation file.
- Double-check that all placeholder tokens (e.g. %1) and newline markers match the source strings exactly to avoid runtime formatting issues.
- Review the <location> attributes in desktop_lo.ts to ensure the desktop entry keys (Name, Comment, GenericName) are correctly referenced.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review代码审查意见:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JWWTSL, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
log: Translation update
Summary by Sourcery
Add comprehensive Lao (lo) translations for the application UI and desktop entry
Enhancements: