sync: from linuxdeepin/dtkcore #179

deepin-ci-robot · 2026-01-07T08:13:13Z

Synchronize source files from linuxdeepin/dtkcore.

Source-pull-request: linuxdeepin/dtkcore#531

github-actions · 2026-01-07T08:14:22Z

Note

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-13T05:23:42Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-13T07:11:55Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-14T05:05:33Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-14T14:27:12Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

deepin-ci-robot · 2026-01-15T03:06:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-01-15T03:07:44Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-15T12:31:54Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-15T12:51:14Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-16T02:52:38Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-16T02:55:52Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

github-actions · 2026-01-16T03:08:33Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#531

deepin-ci-robot · 2026-01-16T13:31:08Z

deepin pr auto review

Git Diff 代码审查报告

1. 语法逻辑审查

1.1 CMakeLists.txt 修改

优点:

版本控制逻辑改进：引入 DTK5 选项明确区分 DTK5 和 DTK6 构建
版本命名更清晰：使用 DTK_NAME_SUFFIX 替代直接版本号，DTK5 为空，DTK6 为 "6"

问题:

dtkcore.cmake 中存在拼写错误：

option(BUIILD_TESTING "Build tests" OFF)  # "BUILD" 拼写错误

应改为：

option(BUILD_TESTING "Build tests" OFF)

tests/CMakeLists.txt 中地址消毒器(ASan)的配置逻辑改进：

if (CMAKE_BUILD_TYPE STREQUAL "Debug")
    add_compile_options(-fsanitize=address)
    add_link_options(-fsanitize=address)
endif()

这是好的改进，只在 Debug 模式下启用 ASan。

1.2 C++ 代码修改

优点:

LogManager.cpp 中的修复：

// 修复前
} else if (m_fallbackConfig && m_dsgConfig->isInitializeSucceed() && !m_fallbackConfig->rulesIsDefaultValue()) {
// 修复后
} else if (m_fallbackConfig && m_fallbackConfig->isInitializeSucceed() && !m_fallbackConfig->rulesIsDefaultValue()) {

修复了明显的逻辑错误，检查 m_fallbackConfig 的初始化状态而不是 m_dsgConfig 的。

dconfig_org_deepin_dtk_preference.hpp 中的线程安全改进：
- 引入 Data 内部类封装线程相关操作
- 使用 QPointer 防止悬空指针
- 使用原子操作和 CAS (Compare-And-Swap) 保证状态转换的原子性
- 禁止外部 moveToThread 调用，通过重写 event() 方法

问题:

dconfig_org_deepin_dtk_preference.hpp 中存在潜在的内存泄漏风险：

~dconfig_org_deepin_dtk_preference() {
    int oldStatus = m_data->m_status.fetchAndStoreOrdered(static_cast<int>(Data::Status::Destroyed));
    
    if (oldStatus == static_cast<int>(Data::Status::Succeeded)) {
        // When Succeeded, release config object only
        auto config = m_data->m_config.loadRelaxed();
        Q_ASSERT(config);
        config->deleteLater();
        // m_data will be deleted by config's destroyed signal
    } else if (oldStatus == static_cast<int>(Data::Status::Failed) ||
               oldStatus == static_cast<int>(Data::Status::Invalid)) {
        // When Failed or Invalid, directly clean up Data object
        m_data->deleteLater();
    }
}

在 Succeeded 状态下，依赖 config 的 destroyed 信号来删除 m_data，但如果 config 的信号连接出现问题，m_data 可能永远不会被删除。

2. 代码质量审查

2.1 代码结构

命名一致性：版本相关的变量命名从 DTK_VERSION_MAJOR 改为 DTK_VERSION_MAJOR 和 DTK_NAME_SUFFIX，提高了可读性。
代码生成工具改进：dconfig2cpp/main.cpp 生成的代码结构更清晰：
- 引入 Data 内部类封装线程相关操作
- 更好的错误处理和状态管理
- 信号发射现在使用 Qt::QueuedConnection 确保线程安全

2.2 代码注释

生成的代码中增加了更多注释，特别是关于线程安全和状态管理的说明。
CMakeLists.txt 中的注释较少，建议增加更多关于版本控制逻辑的说明。

3. 代码性能审查

原子操作使用：新代码中大量使用原子操作和 CAS，虽然增加了复杂性，但提高了并发性能。
信号连接：使用 Qt::QueuedConnection 确保信号在正确的线程中处理，虽然可能增加轻微延迟，但提高了线程安全性。
内存管理：使用 QPointer 和 deleteLater() 管理对象生命周期，避免了直接删除可能导致的崩溃。

4. 代码安全审查

线程安全：新代码显著提高了线程安全性：
- 使用原子操作保护共享状态
- 禁止外部 moveToThread 调用
- 使用 QPointer 防止访问已删除的对象

输入验证：

if (!config || !config->isValid()) {
    qWarning() << QLatin1String("Failed to create DConfig instance.");
    // 错误处理...
}

增加了对配置对象的有效性检查。

资源泄漏预防：
```
if (config)
    delete config;
```
确保在错误情况下释放资源。

5. 改进建议

修复拼写错误：

option(BUIILD_TESTING "Build tests" OFF)  # 改为 BUILD_TESTING

内存管理改进：在 dconfig_org_deepin_dtk_preference.hpp 中，考虑使用 QScopedPointer 或智能指针管理 m_data，避免潜在的内存泄漏。
错误处理增强：增加更多的错误处理逻辑，特别是在配置初始化失败的情况下。
文档完善：为复杂的线程安全机制添加更详细的文档和示例代码。
测试覆盖：增加单元测试，特别是针对线程安全和状态转换的测试。
性能监控：考虑添加性能监控代码，特别是在高并发场景下，监控原子操作和信号处理的性能影响。

6. 总体评价

这次代码提交主要改进了版本控制逻辑和线程安全性，整体质量较高。主要优点包括：

更清晰的版本管理机制
显著提高的线程安全性
更好的错误处理和资源管理

主要问题包括：

少量拼写错误
潜在的内存管理风险
需要更多的测试覆盖

建议在合并前修复拼写错误，并考虑添加更多的测试用例来验证线程安全机制的正确性。

github-actions · 2026-01-16T13:31:43Z

Note

[静态代码检查]

敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkcore\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | e18a6b5679"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 41,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 05250a0 to 4833e32 Compare January 13, 2026 05:22

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 4833e32 to 8366a1c Compare January 13, 2026 07:10

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 8366a1c to 0d8c3d6 Compare January 14, 2026 05:03

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 0d8c3d6 to 847e158 Compare January 14, 2026 14:25

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 847e158 to 81a530e Compare January 15, 2026 03:06

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 81a530e to b02a3f0 Compare January 15, 2026 12:30

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from b02a3f0 to 9cb61b0 Compare January 15, 2026 12:49

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 9cb61b0 to df42b25 Compare January 16, 2026 02:51

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from df42b25 to daab7f2 Compare January 16, 2026 02:54

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from daab7f2 to 6298f29 Compare January 16, 2026 03:07

sync: from linuxdeepin/dtkcore

6662bdf

Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#531

deepin-ci-robot force-pushed the sync-pr-531-nosync branch from 6298f29 to 6662bdf Compare January 16, 2026 13:30

sync: from linuxdeepin/dtkcore #179

Are you sure you want to change the base?

sync: from linuxdeepin/dtkcore #179

Uh oh!

Conversation

deepin-ci-robot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 7, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 13, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

github-actions bot commented Jan 14, 2026

Uh oh!

deepin-ci-robot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 15, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

deepin-ci-robot commented Jan 16, 2026

deepin pr auto review

Git Diff 代码审查报告

1. 语法逻辑审查

1.1 CMakeLists.txt 修改

1.2 C++ 代码修改

2. 代码质量审查

2.1 代码结构

2.2 代码注释

3. 代码性能审查

4. 代码安全审查

5. 改进建议

6. 总体评价

Uh oh!

github-actions bot commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants