Skip to content

Conversation

@18202781743
Copy link
Contributor

Changed the library dependency version format from major.minor to
major.minor.patch in dh_makeshlibs command. This ensures that the
package dependency includes the full version number (including patch
version) rather than just major and minor components. The modification
updates the cut command from extracting fields 1,2 to fields 1,2,3 to
include all three version components.

This change is necessary to maintain proper dependency resolution and
version compatibility, as the patch version can contain important bug
fixes and security updates that should be considered when determining
package dependencies.

Influence:

  1. Verify that package builds successfully with the new version format
  2. Test package installation and dependency resolution
  3. Check that library dependencies are correctly enforced during
    installation
  4. Validate that the package manager properly handles the full version
    specification

fix: 更新库依赖版本格式

将 dh_makeshlibs 命令中的库依赖版本格式从主版本.次版本更改为主版本.次版
本.修订版本。这确保包依赖包含完整的版本号(包括修订版本),而不仅仅是主
版本和次版本。修改将 cut 命令从提取字段 1,2 更新为字段 1,2,3 以包含所有
三个版本组件。

此变更是必要的,以维护正确的依赖解析和版本兼容性,因为修订版本可能包含重
要的错误修复和安全更新,在确定包依赖时应予以考虑。

Influence:

  1. 验证包是否使用新版本格式成功构建
  2. 测试包安装和依赖解析
  3. 检查库依赖在安装过程中是否正确执行
  4. 验证包管理器是否正确处理完整版本规范

Changed the library dependency version format from major.minor to
major.minor.patch in dh_makeshlibs command. This ensures that the
package dependency includes the full version number (including patch
version) rather than just major and minor components. The modification
updates the cut command from extracting fields 1,2 to fields 1,2,3 to
include all three version components.

This change is necessary to maintain proper dependency resolution and
version compatibility, as the patch version can contain important bug
fixes and security updates that should be considered when determining
package dependencies.

Influence:
1. Verify that package builds successfully with the new version format
2. Test package installation and dependency resolution
3. Check that library dependencies are correctly enforced during
installation
4. Validate that the package manager properly handles the full version
specification

fix: 更新库依赖版本格式

将 dh_makeshlibs 命令中的库依赖版本格式从主版本.次版本更改为主版本.次版
本.修订版本。这确保包依赖包含完整的版本号(包括修订版本),而不仅仅是主
版本和次版本。修改将 cut 命令从提取字段 1,2 更新为字段 1,2,3 以包含所有
三个版本组件。

此变更是必要的,以维护正确的依赖解析和版本兼容性,因为修订版本可能包含重
要的错误修复和安全更新,在确定包依赖时应予以考虑。

Influence:
1. 验证包是否使用新版本格式成功构建
2. 测试包安装和依赖解析
3. 检查库依赖在安装过程中是否正确执行
4. 验证包管理器是否正确处理完整版本规范
@18202781743 18202781743 requested review from BLumia and mhduiy October 30, 2025 12:21
@github-actions
Copy link
Contributor

  • 检测到debian目录文件有变更: debian/rules

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

我来对这个git diff进行审查:

  1. 语法逻辑:
  • 修改的语法是正确的,没有语法错误
  • shell命令 cut -d '.' -f 1,2,3 的使用是正确的,它会提取版本号的前三个部分
  1. 代码质量:
  • 这个修改提高了版本控制的精确度
  • 原来的代码只比较主版本号和次版本号(如6.0),现在会包括补丁版本号(如6.0.1)
  • 这样的修改更合理,因为有时候补丁版本可能包含重要的兼容性修复
  1. 代码性能:
  • 这个修改对性能影响很小
  • 只是增加了一个字段的处理,shell命令的执行时间几乎不受影响
  1. 代码安全:
  • 这个修改不会带来安全风险
  • 版本号的比较本身就是一个安全操作

改进建议:

  1. 考虑添加注释说明为什么需要比较三个版本号,而不是原来的两个版本号
  2. 可以考虑将版本号提取逻辑封装成一个变量,提高代码可读性,例如:
PACKAGE_VERSION := $(shell echo $(VERSION) | cut -d '.' -f 1,2,3)
override_dh_makeshlibs:
	dh_makeshlibs -V "libdtk6gui (>= $(PACKAGE_VERSION))"

总体来说,这是一个合理的改进,提高了版本控制的精确度。建议合并这个修改。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 2d96c85 into linuxdeepin:master Oct 30, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants