sync: from linuxdeepin/dtkgui

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#358

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Note

[静态代码检查]

• 敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkgui\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | 4393cea435"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 48,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

[github-actions]

Note

[静态代码检查]

• 敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkgui\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | 4393cea435"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 48,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

[github-actions]

Note

[静态代码检查]

• 敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkgui\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | 4393cea435"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 48,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

[github-actions]

Note

[静态代码检查]

• 敏感词检查失败, 检测到2个文件存在敏感词

详情

{
    "CMakeLists.txt": [
        {
            "line": "  HOMEPAGE_URL \"https://github.com/linuxdeepin/dtkgui\"",
            "line_number": 9,
            "rule": "S35",
            "reason": "Url link | 4393cea435"
        }
    ],
    "docs/CMakeLists.txt": [
        {
            "line": "execute_process(COMMAND git clone https://github.com/linuxdeepin/doxygen-theme.git --depth=1",
            "line_number": 48,
            "rule": "S35",
            "reason": "Url link | d2deace9b0"
        }
    ]
}

[deepin-ci-robot]

deepin pr auto review

我来对这个CMake配置文件的变更进行审查：

1. 语法逻辑审查：

• 语法正确，没有发现明显的语法错误
• 变量命名规范，逻辑清晰
• 条件判断结构合理

2. 代码质量改进建议：

• 建议在CMakeLists.txt开头添加项目描述注释
• version变量的处理可以更优雅，建议统一使用PROJECT_VERSION相关变量
• DTK5/DTK6的选项控制可以增加更详细的说明注释

3. 代码性能改进建议：

• 将重复的DTK_NAME_SUFFIX替换操作集中处理
• 考虑使用函数或宏来处理版本相关的路径生成

4. 代码安全改进建议：

• 建议增加对DTK5/DTK6选项值的验证
• 添加对VERSION文件读取的错误处理
• 在关键路径操作前增加目录存在性检查

5. 具体改进建议：

# 在文件开头添加项目说明
# DTK GUI module CMake configuration
# This file handles the build configuration for DTK GUI module

# 添加版本文件读取的错误处理
if(NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/VERSION")
    message(FATAL_ERROR "VERSION file not found in ${CMAKE_CURRENT_SOURCE_DIR}")
endif()

# 优化版本变量处理
file(READ "${CMAKE_CURRENT_SOURCE_DIR}/VERSION" FILE_VERSION)
string(STRIP "${FILE_VERSION}" FILE_VERSION)
if(NOT FILE_VERSION MATCHES "^[0-9]+\\.[0-9]+\\.[0-9]+$")
    message(FATAL_ERROR "Invalid version format in VERSION file: ${FILE_VERSION}")
endif()

# 增加DTK5/DTK6选项验证
option(DTK5 "Build DTK5." ON)
if(NOT (DTK5 OR NOT DTK5))
    message(FATAL_ERROR "Invalid DTK5 option value")
endif()

# 集中处理版本相关变量
if(DTK5)
    set(DTK_VERSION_MAJOR "5")
    set(DTK_NAME_SUFFIX "")
else()
    set(DTK_VERSION_MAJOR "6")
    set(DTK_NAME_SUFFIX "6")
endif()

6. 其他建议：

• 建议统一使用${DTK_VERSION}而不是混合使用不同的版本变量
• 考虑添加编译选项的文档说明
• 在关键路径操作前添加目录存在性检查
• 建议在配置文件中添加更多的注释说明各个变量的用途

这些改进将提高代码的可维护性、安全性和可读性。